Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1361633002: Remove the [Un]RegisterVoiceProcessor() API. (Closed)

Created:
5 years, 2 months ago by the sun
Modified:
5 years, 2 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the [Un]RegisterVoiceProcessor() API. BUG=webrtc:4690 R=pthatcher@webrtc.org Committed: https://crrev.com/7d173362d01229fe262df37e34ecb061aee8edc3 Cr-Commit-Position: refs/heads/master@{#10027}

Patch Set 1 #

Patch Set 2 : remove even more #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -567 lines) Patch
M talk/libjingle.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M talk/libjingle_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/base/capturemanager_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 1 2 4 chunks +1 line, -39 lines 0 comments Download
M talk/media/base/fakemediaprocessor.h View 1 1 chunk +2 lines, -34 lines 0 comments Download
M talk/media/base/mediaengine.h View 1 2 3 chunks +0 lines, -25 lines 0 comments Download
M talk/media/base/videocapturer_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M talk/media/base/voiceprocessor.h View 1 1 chunk +2 lines, -30 lines 0 comments Download
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 2 3 9 chunks +2 lines, -49 lines 0 comments Download
M talk/media/webrtc/webrtcvoe.h View 1 2 3 5 chunks +1 line, -5 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 2 3 5 chunks +1 line, -44 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 2 3 6 chunks +2 lines, -188 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 2 3 3 chunks +0 lines, -82 lines 0 comments Download
M talk/session/media/channelmanager.h View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M talk/session/media/channelmanager.cc View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
M talk/session/media/channelmanager_unittest.cc View 1 3 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
the sun
5 years, 2 months ago (2015-09-22 15:29:08 UTC) #3
pthatcher1
lgtm
5 years, 2 months ago (2015-09-22 18:27:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361633002/40001
5 years, 2 months ago (2015-09-23 08:33:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/9375)
5 years, 2 months ago (2015-09-23 08:52:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361633002/40001
5 years, 2 months ago (2015-09-23 09:01:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/40)
5 years, 2 months ago (2015-09-23 09:25:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361633002/60001
5 years, 2 months ago (2015-09-23 10:16:01 UTC) #16
the sun
Committed patchset #4 (id:60001) manually as 7d173362d01229fe262df37e34ecb061aee8edc3 (presubmit successful).
5 years, 2 months ago (2015-09-23 10:23:38 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 10:23:41 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7d173362d01229fe262df37e34ecb061aee8edc3
Cr-Commit-Position: refs/heads/master@{#10027}

Powered by Google App Engine
This is Rietveld 408576698