Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 1361263002: Revert of Adding PeerConnectionInterface::SetConfiguration method. (Closed)

Created:
5 years, 3 months ago by Taylor Brandstetter
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding PeerConnectionInterface::SetConfiguration method. (patchset #4 id:60001 of https://codereview.webrtc.org/1317353005/ ) Reason for revert: Broke FYI bots because SetConfiguration is pure virtual and MockPeerConnectionImpl doesn't implement it. Need to reland with SetConfiguration not pure virtual. Original issue's description: > Adding PeerConnectionInterface::SetConfiguration method. > > Also updated the JNI and Objective-C bindings. Later, will have a CL to > remove UpdateIce, which this method effectively replaces. > > BUG=webrtc:4945 > > Committed: https://crrev.com/70702afbcb8418fe93747e7ed63bcbf5e56b90e9 > Cr-Commit-Position: refs/heads/master@{#10040} TBR=guoweis@webrtc.org,pthatcher@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4945 Committed: https://crrev.com/7603c76ab077b1e2033bb179595129bd96797345 Cr-Commit-Position: refs/heads/master@{#10041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -133 lines) Patch
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 3 chunks +63 lines, -70 lines 0 comments Download
M talk/app/webrtc/java/src/org/webrtc/PeerConnection.java View 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCPeerConnection.mm View 1 chunk +7 lines, -3 lines 0 comments Download
M talk/app/webrtc/objc/public/RTCPeerConnection.h View 2 chunks +4 lines, -7 lines 0 comments Download
M talk/app/webrtc/peerconnection.h View 1 chunk +37 lines, -37 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 chunk +0 lines, -8 lines 0 comments Download
M talk/app/webrtc/peerconnectionproxy.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Taylor Brandstetter
Created Revert of Adding PeerConnectionInterface::SetConfiguration method.
5 years, 3 months ago (2015-09-24 00:30:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361263002/1
5 years, 3 months ago (2015-09-24 00:30:47 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-24 00:30:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361263002/1
5 years, 3 months ago (2015-09-24 00:36:09 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-24 00:36:11 UTC) #8
tkchin_webrtc
On 2015/09/24 00:36:11, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 3 months ago (2015-09-24 00:36:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361263002/1
5 years, 3 months ago (2015-09-24 00:37:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 00:37:20 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7603c76ab077b1e2033bb179595129bd96797345 Cr-Commit-Position: refs/heads/master@{#10041}
5 years, 3 months ago (2015-09-24 00:37:27 UTC) #13
Taylor Brandstetter
5 years, 3 months ago (2015-09-24 00:44:51 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1361273002/ by deadbeef@webrtc.org.

The reason for reverting is: Relanding with SetConfiguration not pure virtual..

Powered by Google App Engine
This is Rietveld 408576698