talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h - Issue 1361213002: Adding 20-second timeout to Java and Objective-C tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h

Issue 1361213002: Adding 20-second timeout to Java and Objective-C tests. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « talk/app/webrtc/java/testcommon/src/org/webrtc/PeerConnectionTest.java ('k') | talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m » ('j') | talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h

diff --git a/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h b/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h

index 436515fa7c9906b0d81fd3e56d929f69e3a6c383..51217eba8635f56361d4f8fbd63132d74d8f2ff4 100644

--- a/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h

+++ b/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.h

@@ -54,6 +54,7 @@

- (void)expectMessage:(NSData*)message isBinary:(BOOL)isBinary;

// Wait until all registered expectations above have been observed.

-- (void)waitForAllExpectationsToBeSatisfied;

+// Return false if expectations aren't met within |timeoutSeconds|.

+- (BOOL)waitForAllExpectationsToBeSatisfiedWithTimeout:(int)timeoutSeconds;

tkchin_webrtc 2015/09/25 15:40:32 Don't use int type in ObjC unless you're interop-i

Taylor Brandstetter 2015/09/25 18:01:57 Done.

@end