Enable logging for Mac by default on debug builds.

Enable logging for Mac by default on debug builds.

Was previously using the wrong preprocessor define (DEBUG vs _DEBUG).

Committed: https://crrev.com/59e72ab49b05febceffa38c815e79d690305c95f
Cr-Commit-Position: refs/heads/master@{#10061}

[Taylor Brandstetter, 2015-09-23 18:08:34]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2015-09-23 18:08:34]

https://codereview.webrtc.org/1361173002/diff/1/webrtc/base/logging.cc
File webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1361173002/diff/1/webrtc/base/logging.cc#newcod...
webrtc/base/logging.cc:350: #if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS) &&
!defined(_DEBUG)
I removed the "NDEBUG" check because NDEBUG controls whether asserts are
enabled, and that's not relevant here.

[pthatcher1, 2015-09-23 18:12:11]

pthatcher@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[pthatcher1, 2015-09-23 18:12:11]

https://codereview.webrtc.org/1361173002/diff/1/webrtc/base/logging.cc
File webrtc/base/logging.cc (right):

https://codereview.webrtc.org/1361173002/diff/1/webrtc/base/logging.cc#newcod...
webrtc/base/logging.cc:350: #if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS) &&
!defined(_DEBUG)
On 2015/09/23 18:08:34, Taylor Brandstetter wrote:
> I removed the "NDEBUG" check because NDEBUG controls whether asserts are
> enabled, and that's not relevant here.

But are any applications going to set NDEBUG and now be surprised when they get
different logging behavior?

[Taylor Brandstetter, 2015-09-23 18:16:46]

On 2015/09/23 18:12:11, pthatcher1 wrote:
> https://codereview.webrtc.org/1361173002/diff/1/webrtc/base/logging.cc
> File webrtc/base/logging.cc (right):
> 
>
https://codereview.webrtc.org/1361173002/diff/1/webrtc/base/logging.cc#newcod...
> webrtc/base/logging.cc:350: #if defined(WEBRTC_MAC) && !defined(WEBRTC_IOS) &&
> !defined(_DEBUG)
> On 2015/09/23 18:08:34, Taylor Brandstetter wrote:
> > I removed the "NDEBUG" check because NDEBUG controls whether asserts are
> > enabled, and that's not relevant here.
> 
> But are any applications going to set NDEBUG and now be surprised when they
get
> different logging behavior?

Ok, I guess I'll leave it in since it doesn't hurt anything for us.

[pthatcher1, 2015-09-23 19:39:45]

lgtm

[Taylor Brandstetter, 2015-09-23 20:00:43]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2015-09-23 20:00:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361173002/20001

[commit-bot: I haz the power, 2015-09-23 22:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 22:01:11]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[Taylor Brandstetter, 2015-09-24 17:41:19]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2015-09-24 17:41:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361173002/20001

[commit-bot: I haz the power, 2015-09-24 17:42:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 17:42:57]

Patchset 2 (id:??) landed as
https://crrev.com/59e72ab49b05febceffa38c815e79d690305c95f
Cr-Commit-Position: refs/heads/master@{#10061}