Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1361083002: Android AppRTCDemo: Add slider for changing camera capture quality during call (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android AppRTCDemo: Add slider for changing camera capture quality during call This CL adds a slider that can change capture resolution and fps during a call. The camera will no be reconfigured, but the frames will be downscaled/dropped in software by cricket::VideoAdapter in the cricket::VideoCapturer. This is controlled with VideoCapturerAndroid.onOutputFormatRequest(). The slider is turned off by default and can be enabled with a checkbox under 'WebRTC Video Settings'. R=glaznev@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/67e0cf15d323642516f40b619f6474db333524a7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move programmatic layout changes into fragment_call.xml instead #

Messages

Total messages: 7 (1 generated)
magjed_webrtc
Alex - please take a look.
5 years, 3 months ago (2015-09-23 17:46:10 UTC) #2
AlexG
https://codereview.webrtc.org/1361083002/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java File webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java (right): https://codereview.webrtc.org/1361083002/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java#newcode119 webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java:119: final TextView captureFormatText = new TextView(getActivity()); I think it ...
5 years, 3 months ago (2015-09-23 23:56:38 UTC) #3
magjed_webrtc
https://codereview.webrtc.org/1361083002/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java File webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java (right): https://codereview.webrtc.org/1361083002/diff/1/webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java#newcode119 webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java:119: final TextView captureFormatText = new TextView(getActivity()); On 2015/09/23 23:56:38, ...
5 years, 3 months ago (2015-09-24 15:08:17 UTC) #4
AlexG
lgtm
5 years, 3 months ago (2015-09-24 16:47:37 UTC) #5
magjed_webrtc
Committed patchset #2 (id:20001) manually as 67e0cf15d323642516f40b619f6474db333524a7 (presubmit successful).
5 years, 2 months ago (2015-09-25 06:23:55 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 06:23:55 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67e0cf15d323642516f40b619f6474db333524a7
Cr-Commit-Position: refs/heads/master@{#10067}

Powered by Google App Engine
This is Rietveld 408576698