Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1360773002: Remove VoEFile from VoeWrapper and the remaining places in libjingle where it was being used. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoEFile from VoeWrapper and the remaining places in libjingle where it was being used. BUG=webrtc:4690 R=pbos@webrtc.org Committed: https://crrev.com/09677342ae9dce4f4ec9c294342a8b1789dcdba2 Cr-Commit-Position: refs/heads/master@{#10026}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -76 lines) Patch
M talk/media/webrtc/fakewebrtcvoiceengine.h View 1 4 chunks +1 line, -61 lines 0 comments Download
M talk/media/webrtc/webrtcvoe.h View 5 chunks +1 line, -5 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
the sun
5 years, 3 months ago (2015-09-22 20:38:31 UTC) #2
pbos-webrtc
lgtm
5 years, 3 months ago (2015-09-23 09:31:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360773002/40001
5 years, 3 months ago (2015-09-23 09:36:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/4097)
5 years, 3 months ago (2015-09-23 10:01:52 UTC) #8
the sun
Committed patchset #4 (id:60001) manually as 09677342ae9dce4f4ec9c294342a8b1789dcdba2 (presubmit successful).
5 years, 3 months ago (2015-09-23 10:05:54 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 10:05:59 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/09677342ae9dce4f4ec9c294342a8b1789dcdba2
Cr-Commit-Position: refs/heads/master@{#10026}

Powered by Google App Engine
This is Rietveld 408576698