Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1360173002: VideoCapturerAndroid: Add custom nativeCreateVideoCapturer() (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 2 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Add custom nativeCreateVideoCapturer() This CL shouldn't make any functional changes. It adds a new VideoCapturerAndroid.nativeCreateVideoCapturer() instead of always using VideoCapturer.nativeCreateVideoCapturer(). The purpose is to simplify androidvideocapturer_jni and VideoCapturerAndroid.create(). This way, it is possible to use the ctor instead of VideoCapturerAndroid.init() to initialize variables, and they can be made final etc. R=perkj@webrtc.org Committed: https://crrev.com/e0bce240652bcf4031ae61985938e968469d3f53 Cr-Commit-Position: refs/heads/master@{#10171}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -78 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/VideoCapturerAndroid.java View 5 chunks +31 lines, -31 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.h View 2 chunks +4 lines, -10 lines 0 comments Download
M talk/app/webrtc/java/jni/androidvideocapturer_jni.cc View 3 chunks +10 lines, -26 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
magjed_webrtc
perkj - Please take a look.
5 years, 2 months ago (2015-10-05 08:27:57 UTC) #3
perkj_webrtc
On 2015/10/05 08:27:57, magjed_webrtc wrote: > perkj - Please take a look. Nice. lgtm
5 years, 2 months ago (2015-10-05 11:16:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360173002/20001
5 years, 2 months ago (2015-10-05 11:16:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 2 months ago (2015-10-05 13:17:14 UTC) #8
perkj_webrtc
Committed patchset #1 (id:20001) manually as e0bce240652bcf4031ae61985938e968469d3f53 (presubmit successful).
5 years, 2 months ago (2015-10-05 14:22:14 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 14:22:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0bce240652bcf4031ae61985938e968469d3f53
Cr-Commit-Position: refs/heads/master@{#10171}

Powered by Google App Engine
This is Rietveld 408576698