Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1360123002: ACMCodecDB: Remove unused stuff, and move private stuff to anonymous namespace (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ACMCodecDB: Remove unused stuff, and move private stuff to anonymous namespace BUG=webrtc:5028 Committed: https://crrev.com/ec249d4eae9bedef96e7688c5d8d1d559610d502 Cr-Commit-Position: refs/heads/master@{#10048}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -192 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.h View 2 chunks +0 lines, -42 lines 0 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc View 4 chunks +55 lines, -150 lines 1 comment Download

Messages

Total messages: 11 (4 generated)
kwiberg-webrtc
🔥🔥🔥
5 years, 3 months ago (2015-09-23 11:00:19 UTC) #2
hlundin-webrtc
lgtm https://codereview.webrtc.org/1360123002/diff/1/webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc File webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc (left): https://codereview.webrtc.org/1360123002/diff/1/webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc#oldcode359 webrtc/modules/audio_coding/main/acm2/acm_codec_database.cc:359: const NetEqDecoder* ACMCodecDB::NetEQDecoders() { So, the getter is ...
5 years, 3 months ago (2015-09-23 14:42:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360123002/1
5 years, 3 months ago (2015-09-24 10:48:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/9749)
5 years, 3 months ago (2015-09-24 11:13:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360123002/1
5 years, 3 months ago (2015-09-24 11:21:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 11:32:09 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 11:32:20 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ec249d4eae9bedef96e7688c5d8d1d559610d502
Cr-Commit-Position: refs/heads/master@{#10048}

Powered by Google App Engine
This is Rietveld 408576698