Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1359983003: Add myself as OWNER of webrtc/voice_engine and talk/media/webrtc. (Closed)

Created:
5 years, 3 months ago by the sun
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add myself as OWNER of webrtc/voice_engine and talk/media/webrtc. BUG=webrtc:4690 R=mflodman@webrtc.org, tina.legrand@webrtc.org Committed: https://crrev.com/d0b5b091e4f2724ed2aaf79a77d00487e041f642 Cr-Commit-Position: refs/heads/master@{#10035}

Patch Set 1 #

Patch Set 2 : Add myself as OWNER. #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M talk/media/webrtc/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/voice_engine/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
the sun
5 years, 3 months ago (2015-09-23 15:02:49 UTC) #2
tlegrand-webrtc
On 2015/09/23 15:02:49, the sun wrote: LGTM, with a small suggestion.
5 years, 3 months ago (2015-09-23 15:06:43 UTC) #3
tlegrand-webrtc
...and here it comes. :) https://codereview.webrtc.org/1359983003/diff/20001/webrtc/voice_engine/OWNERS File webrtc/voice_engine/OWNERS (right): https://codereview.webrtc.org/1359983003/diff/20001/webrtc/voice_engine/OWNERS#newcode5 webrtc/voice_engine/OWNERS:5: xians@webrtc.org I think you ...
5 years, 3 months ago (2015-09-23 15:08:39 UTC) #4
mflodman
talk/media/webrtc/OWNERS LGTM
5 years, 3 months ago (2015-09-23 15:11:08 UTC) #5
the sun
https://codereview.webrtc.org/1359983003/diff/20001/webrtc/voice_engine/OWNERS File webrtc/voice_engine/OWNERS (right): https://codereview.webrtc.org/1359983003/diff/20001/webrtc/voice_engine/OWNERS#newcode5 webrtc/voice_engine/OWNERS:5: xians@webrtc.org On 2015/09/23 15:08:39, tlegrand-webrtc wrote: > I think ...
5 years, 3 months ago (2015-09-23 15:14:34 UTC) #6
the sun
Committed patchset #3 (id:40001) manually as d0b5b091e4f2724ed2aaf79a77d00487e041f642 (presubmit successful).
5 years, 3 months ago (2015-09-23 15:15:36 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 15:15:40 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d0b5b091e4f2724ed2aaf79a77d00487e041f642
Cr-Commit-Position: refs/heads/master@{#10035}

Powered by Google App Engine
This is Rietveld 408576698