Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Issue 1359783002: Using static frame generator when no scrolling (Closed)

Created:
5 years, 3 months ago by ivica
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman, sprang_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Using static frame generator when no scrolling In screensharing full stack tests, instead of using YuvFileGenerator by default when no scrolling is used, I always used ScrollingImageFileGenerator. That possibly slowed down the test a little bit, at least for the slowed devices, as it unnecessarily copied few MBs per frame. BUG=chromium:534220 Committed: https://crrev.com/d4818e73042bc2402256977884c04d96084327fb Cr-Commit-Position: refs/heads/master@{#10014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M webrtc/video/video_quality_test.cc View 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ivica
5 years, 3 months ago (2015-09-22 07:59:59 UTC) #2
pbos-webrtc
lgtm
5 years, 3 months ago (2015-09-22 08:57:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359783002/1
5 years, 3 months ago (2015-09-22 08:59:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 3 months ago (2015-09-22 10:59:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359783002/1
5 years, 3 months ago (2015-09-22 12:46:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 12:47:34 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 12:47:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4818e73042bc2402256977884c04d96084327fb
Cr-Commit-Position: refs/heads/master@{#10014}

Powered by Google App Engine
This is Rietveld 408576698