webrtc/modules/video_coding/main/source/generic_decoder.cc - Issue 1358863002: Simplify VCMTimestampMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/main/source/generic_decoder.cc

Issue 1358863002: Simplify VCMTimestampMap. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/main/source/generic_decoder.cc

diff --git a/webrtc/modules/video_coding/main/source/generic_decoder.cc b/webrtc/modules/video_coding/main/source/generic_decoder.cc

index 1cd67dfddfbb2a176bcfb48dc697e58cbeb83a30..408137bb528ca05590898bfaf4f032f8257ade9d 100644

--- a/webrtc/modules/video_coding/main/source/generic_decoder.cc

+++ b/webrtc/modules/video_coding/main/source/generic_decoder.cc

@@ -103,10 +103,10 @@ uint64_t VCMDecodedFrameCallback::LastReceivedPictureID() const

return _lastReceivedPictureID;

}

-int32_t VCMDecodedFrameCallback::Map(uint32_t timestamp, VCMFrameInformation* frameInfo)

- CriticalSectionScoped cs(_critSect);

- return _timestampMap.Add(timestamp, frameInfo);

+void VCMDecodedFrameCallback::Map(uint32_t timestamp,

+ VCMFrameInformation* frameInfo) {

+ CriticalSectionScoped cs(_critSect);

+ _timestampMap.Add(timestamp, frameInfo);

}

int32_t VCMDecodedFrameCallback::Pop(uint32_t timestamp)