Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1358863002: Simplify VCMTimestampMap. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 2 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Simplify VCMTimestampMap. Fixes code formatting and uses size_t properly. Also makes use of IsNewerTimestamp instead of a simple > check, which should fix an edge-case bug. BUG= R=stefan@webrtc.org Committed: https://crrev.com/1968d3f357f3cb01c4fdd3d9e89e22a1f0d6660a Cr-Commit-Position: refs/heads/master@{#10094}

Patch Set 1 #

Total comments: 12

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -103 lines) Patch
M webrtc/modules/video_coding/main/source/generic_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/main/source/generic_decoder.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/main/source/timestamp_map.h View 1 1 chunk +21 lines, -26 lines 0 comments Download
M webrtc/modules/video_coding/main/source/timestamp_map.cc View 1 1 chunk +36 lines, -70 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
pbos-webrtc
PTAL, pay extra attention to IsNewerTimestamp
5 years, 3 months ago (2015-09-21 14:09:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358863002/1
5 years, 3 months ago (2015-09-21 14:09:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 15:01:24 UTC) #5
stefan-webrtc
https://codereview.webrtc.org/1358863002/diff/1/webrtc/modules/video_coding/main/source/timestamp_map.cc File webrtc/modules/video_coding/main/source/timestamp_map.cc (right): https://codereview.webrtc.org/1358863002/diff/1/webrtc/modules/video_coding/main/source/timestamp_map.cc#newcode19 webrtc/modules/video_coding/main/source/timestamp_map.cc:19: VCMTimestampMap::VCMTimestampMap(size_t length) Named length here, size in the .h ...
5 years, 3 months ago (2015-09-21 15:15:47 UTC) #6
pbos-webrtc
feedback
5 years, 3 months ago (2015-09-23 13:51:49 UTC) #7
pbos-webrtc
https://codereview.webrtc.org/1358863002/diff/1/webrtc/modules/video_coding/main/source/timestamp_map.cc File webrtc/modules/video_coding/main/source/timestamp_map.cc (right): https://codereview.webrtc.org/1358863002/diff/1/webrtc/modules/video_coding/main/source/timestamp_map.cc#newcode19 webrtc/modules/video_coding/main/source/timestamp_map.cc:19: VCMTimestampMap::VCMTimestampMap(size_t length) On 2015/09/21 15:15:46, stefan-webrtc (holmer) wrote: > ...
5 years, 3 months ago (2015-09-23 13:51:55 UTC) #8
stefan-webrtc
lgtm
5 years, 2 months ago (2015-09-28 13:42:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358863002/20001
5 years, 2 months ago (2015-09-28 13:48:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 15:52:23 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 15:56:00 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1968d3f357f3cb01c4fdd3d9e89e22a1f0d6660a
Cr-Commit-Position: refs/heads/master@{#10094}

Powered by Google App Engine
This is Rietveld 408576698