Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1358413003: Revert of TransportController refactoring. (Closed)

Created:
5 years, 3 months ago by torbjorng (webrtc)
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of TransportController refactoring. (patchset #6 id:100001 of https://codereview.webrtc.org/1350523003/ ) Reason for revert: This CL causes problems with the WebRTC-in-Chromium FYI bots. Presumably it needs to be done in several steps, where removed files are emptied instead of removed in the first step. Original issue's description: > TransportController refactoring. > > Getting rid of TransportProxy, and in its place adding a > TransportController class which will facilitate access to and manage > the lifetimes of Transports. These Transports will now be accessed > solely from the worker thread, simplifying their implementation. > > This refactoring also pulls Transport-related code out of BaseSession. > Which means that BaseChannels will now rely on the TransportController > interface to create channels, rather than BaseSession. > > Committed: https://crrev.com/47ee2f3b9f33e8938948c482c921d4e13a3acd83 > Cr-Commit-Position: refs/heads/master@{#10022} TBR=pthatcher@webrtc.org,deadbeef@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a81a42f584baa0d93a4b93da9632415e8922450c Cr-Commit-Position: refs/heads/master@{#10024}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3624 lines, -3781 lines) Patch
M talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m View 2 chunks +2 lines, -8 lines 0 comments Download
M talk/app/webrtc/objctests/RTCPeerConnectionTest.mm View 1 chunk +1 line, -4 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M talk/app/webrtc/statscollector.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 21 chunks +73 lines, -99 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 9 chunks +24 lines, -34 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 34 chunks +199 lines, -278 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 36 chunks +112 lines, -211 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.h View 1 chunk +7 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 3 chunks +8 lines, -12 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M talk/session/media/channel.h View 12 chunks +28 lines, -41 lines 0 comments Download
M talk/session/media/channel.cc View 19 chunks +88 lines, -144 lines 0 comments Download
M talk/session/media/channel_unittest.cc View 36 chunks +60 lines, -105 lines 0 comments Download
M talk/session/media/channelmanager.h View 3 chunks +11 lines, -12 lines 0 comments Download
M talk/session/media/channelmanager.cc View 6 chunks +32 lines, -25 lines 0 comments Download
M talk/session/media/channelmanager_unittest.cc View 8 chunks +31 lines, -42 lines 0 comments Download
M webrtc/base/fakenetwork.h View 4 chunks +20 lines, -13 lines 0 comments Download
M webrtc/p2p/base/dtlstransport.h View 7 chunks +32 lines, -23 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 8 chunks +29 lines, -26 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 4 chunks +24 lines, -17 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 14 chunks +50 lines, -44 lines 0 comments Download
A webrtc/p2p/base/fakesession.h View 1 chunk +506 lines, -0 lines 0 comments Download
D webrtc/p2p/base/faketransportcontroller.h View 1 chunk +0 lines, -537 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.h View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 9 chunks +25 lines, -22 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 15 chunks +70 lines, -58 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 33 chunks +71 lines, -62 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 3 chunks +7 lines, -11 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M webrtc/p2p/base/session.h View 8 chunks +284 lines, -15 lines 0 comments Download
M webrtc/p2p/base/session.cc View 9 chunks +606 lines, -49 lines 0 comments Download
A webrtc/p2p/base/session_unittest.cc View 1 chunk +100 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transport.h View 15 chunks +154 lines, -106 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 17 chunks +524 lines, -270 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 5 chunks +21 lines, -4 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 3 chunks +6 lines, -10 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 4 chunks +13 lines, -13 lines 0 comments Download
A webrtc/p2p/base/transportchannelproxy.h View 1 chunk +96 lines, -0 lines 0 comments Download
A webrtc/p2p/base/transportchannelproxy.cc View 1 chunk +276 lines, -0 lines 0 comments Download
D webrtc/p2p/base/transportcontroller.h View 1 chunk +0 lines, -196 lines 0 comments Download
D webrtc/p2p/base/transportcontroller.cc View 1 chunk +0 lines, -575 lines 0 comments Download
D webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +0 lines, -679 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/p2p_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
torbjorng (webrtc)
Created Revert of TransportController refactoring.
5 years, 3 months ago (2015-09-23 09:16:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358413003/1
5 years, 3 months ago (2015-09-23 09:16:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 09:17:04 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a81a42f584baa0d93a4b93da9632415e8922450c Cr-Commit-Position: refs/heads/master@{#10024}
5 years, 3 months ago (2015-09-23 09:24:33 UTC) #4
Taylor Brandstetter
5 years, 3 months ago (2015-09-23 18:37:45 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1361773005/ by deadbeef@webrtc.org.

The reason for reverting is: This CL just landed:
https://codereview.chromium.org/1323243006/

Which fixes the FYI bots for the original CL, and breaks them for this revert..

Powered by Google App Engine
This is Rietveld 408576698