Fixing camera capture for video_loopback

Fixing camera capture for video_loopback

In the middle of refactoring, I replaced the VideoCapturer with
FrameGeneratorCapturer, to reuse the code, and with that disabled the camera.
Now adding capturer_ element to VideoQualityTest and ignoring
frame_generator_capturer_ from the parent class test::CallTest.

Committed: https://crrev.com/2d4e6c5d9d7b48aec62d1cda9f75fe0b695167aa
Cr-Commit-Position: refs/heads/master@{#10023}

[ivica, 2015-09-21 15:53:36]

ivica@webrtc.org changed reviewers:
+ pbos@webrtc.org, sprang@webrtc.org

[ivica, 2015-09-21 15:53:37]

...I believe more and more that VideoQualityTest should just reimplement
everything it needs from test::CallTest, instead of deriving it.

[ivica, 2015-09-21 15:55:49]

The CQ bit was checked by ivica@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 15:55:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1356933005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1356933005/1

[commit-bot: I haz the power, 2015-09-21 15:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 15:59:38]

Dry run: Try jobs failed on following builders:
  mac on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac/builds/9799)

[pbos-webrtc, 2015-09-21 16:09:11]

https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
File webrtc/video/video_quality_test.h (right):

https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.h:70: // Own variants that use capturer_ instead
of frame_generator_capturer_.
Should frame_generator_capturer_ in test::CallTest just be a
webrtc::VideoCapturer? Or do we not have access to start/stop there?

https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.h:71: void Start();
Are these overriding anything? Where are they called?

[pbos-webrtc, 2015-09-21 16:09:27]

On 2015/09/21 16:09:11, pbos-webrtc wrote:
>
https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
> File webrtc/video/video_quality_test.h (right):
> 
>
https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
> webrtc/video/video_quality_test.h:70: // Own variants that use capturer_
instead
> of frame_generator_capturer_.
> Should frame_generator_capturer_ in test::CallTest just be a
> webrtc::VideoCapturer? Or do we not have access to start/stop there?
> 
>
https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
> webrtc/video/video_quality_test.h:71: void Start();
> Are these overriding anything? Where are they called?

Basically: Should test::CallTest be fixed instead?

[ivica, 2015-09-21 16:17:53]

https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
File webrtc/video/video_quality_test.h (right):

https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.h:70: // Own variants that use capturer_ instead
of frame_generator_capturer_.
On 2015/09/21 16:09:10, pbos-webrtc wrote:
> Should frame_generator_capturer_ in test::CallTest just be a
> webrtc::VideoCapturer? Or do we not have access to start/stop there?

There is some code that uses CallTest and assumes capturer is
FrameGeneratorCapturer, so I cannot just change CallTest.

https://codereview.webrtc.org/1356933005/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.h:71: void Start();
On 2015/09/21 16:09:10, pbos-webrtc wrote:
> Are these overriding anything? Where are they called?

CallTest has Start(), Stop(), but non-virtual.
They are called in video/video_quality_test.cc in RunWithAnalyzer.
Now when I think of it, I could've had just copied that directly into the
RunwithAnalyzer, without introducing Start and Stop.
RunWithRenderer anyway has its own code to start and stop the call.

[ivica, 2015-09-21 17:17:24]

The CQ bit was checked by ivica@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 17:17:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1356933005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1356933005/20001

[commit-bot: I haz the power, 2015-09-21 19:17:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 19:17:48]

Dry run: Try jobs failed on following builders:
  android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ivica, 2015-09-22 07:46:33]

The CQ bit was checked by ivica@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-22 07:46:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1356933005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1356933005/40001

[commit-bot: I haz the power, 2015-09-22 09:36:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 09:36:17]

Dry run: This issue passed the CQ dry run.

[pbos-webrtc, 2015-09-22 11:26:10]

https://codereview.webrtc.org/1356933005/diff/40001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/1356933005/diff/40001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:699:
capturer_.reset(frame_generator_capturer);
Just do capturer_.reset(.. above and assert that capturer_.get() != nullptr

[pbos-webrtc, 2015-09-22 11:27:09]

lgtm with this changed

[ivica, 2015-09-22 11:35:47]

The CQ bit was checked by ivica@webrtc.org

[ivica, 2015-09-22 11:35:47]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1356933005/#ps60001 (title:
"Addressing comments")

[commit-bot: I haz the power, 2015-09-22 11:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1356933005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1356933005/60001

[ivica, 2015-09-22 11:35:59]

https://codereview.webrtc.org/1356933005/diff/40001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/1356933005/diff/40001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:699:
capturer_.reset(frame_generator_capturer);
On 2015/09/22 11:26:10, pbos-webrtc wrote:
> Just do capturer_.reset(.. above and assert that capturer_.get() != nullptr

Done.

[commit-bot: I haz the power, 2015-09-22 12:07:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 12:07:59]

Try jobs failed on following builders:
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/2186)

[ivica, 2015-09-22 12:46:40]

The CQ bit was checked by ivica@webrtc.org

[commit-bot: I haz the power, 2015-09-22 12:46:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1356933005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1356933005/60001

[commit-bot: I haz the power, 2015-09-22 13:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-22 13:36:11]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ivica, 2015-09-23 08:56:00]

The CQ bit was checked by ivica@webrtc.org

[commit-bot: I haz the power, 2015-09-23 08:56:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1356933005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1356933005/60001

[commit-bot: I haz the power, 2015-09-23 08:57:11]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-23 08:57:20]

Patchset 4 (id:??) landed as
https://crrev.com/2d4e6c5d9d7b48aec62d1cda9f75fe0b695167aa
Cr-Commit-Position: refs/heads/master@{#10023}