Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1356293002: Android: Add class ThreadUtils with helper function joinUninterruptibly() (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Add class ThreadUtils with helper function joinUninterruptibly() R=hbos@webrtc.org Committed: https://crrev.com/82122650536e0a96b5d999b635e04a499e5d9b46 Cr-Commit-Position: refs/heads/master@{#10016}

Patch Set 1 #

Patch Set 2 : Rename to ThreadUtils and add extra comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -42 lines) Patch
M talk/app/webrtc/java/android/org/webrtc/SurfaceViewRenderer.java View 1 1 chunk +2 lines, -17 lines 0 comments Download
A + talk/app/webrtc/java/android/org/webrtc/ThreadUtils.java View 1 1 chunk +21 lines, -25 lines 0 comments Download
M talk/libjingle.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
magjed_webrtc
hbos - Please take a look.
5 years, 3 months ago (2015-09-22 12:52:32 UTC) #2
hbos
lgtm Optional: ThreadUtils instead of ThreadUtilities for the less characters.
5 years, 3 months ago (2015-09-22 12:56:00 UTC) #3
hbos
On 2015/09/22 12:56:00, hbos wrote: > lgtm > > Optional: ThreadUtils instead of ThreadUtilities for ...
5 years, 3 months ago (2015-09-22 12:57:19 UTC) #4
magjed_webrtc
Done.
5 years, 3 months ago (2015-09-22 13:16:27 UTC) #5
magjed_webrtc
Committed patchset #2 (id:20001) manually as 82122650536e0a96b5d999b635e04a499e5d9b46 (presubmit successful).
5 years, 3 months ago (2015-09-22 13:17:28 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 13:17:31 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82122650536e0a96b5d999b635e04a499e5d9b46
Cr-Commit-Position: refs/heads/master@{#10016}

Powered by Google App Engine
This is Rietveld 408576698