Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1356123002: Fixing target_bitrate_bps for a FullStackTest (Closed)

Created:
5 years, 3 months ago by ivica
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman, sprang_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing target_bitrate_bps for a FullStackTest While refactoring, I incorrectly set the target bitrate for one of the tests to 500k instead of 2000k. This does not fix all the perf regressions. BUG=chromium:534220 Committed: https://crrev.com/1356ba5e6ceb7513137b4052f0c2f9edddb11d5e Cr-Commit-Position: refs/heads/master@{#10008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/video/full_stack.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356123002/1
5 years, 3 months ago (2015-09-21 16:00:04 UTC) #2
ivica
5 years, 3 months ago (2015-09-21 16:00:45 UTC) #4
pbos-webrtc
lgtm
5 years, 3 months ago (2015-09-21 16:06:28 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL) ...
5 years, 3 months ago (2015-09-21 18:00:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356123002/1
5 years, 3 months ago (2015-09-22 07:36:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 08:09:15 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 08:09:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1356ba5e6ceb7513137b4052f0c2f9edddb11d5e
Cr-Commit-Position: refs/heads/master@{#10008}

Powered by Google App Engine
This is Rietveld 408576698