Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: webrtc/p2p/base/transportchannel.h

Issue 1356103002: Revert of Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/p2p/base/transport.cc ('k') | webrtc/p2p/base/transportchannel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 28 matching lines...) Expand all
39 // Used to indicate channel's connection state. 39 // Used to indicate channel's connection state.
40 enum TransportChannelState { STATE_CONNECTING, STATE_COMPLETED, STATE_FAILED }; 40 enum TransportChannelState { STATE_CONNECTING, STATE_COMPLETED, STATE_FAILED };
41 41
42 // A TransportChannel represents one logical stream of packets that are sent 42 // A TransportChannel represents one logical stream of packets that are sent
43 // between the two sides of a session. 43 // between the two sides of a session.
44 class TransportChannel : public sigslot::has_slots<> { 44 class TransportChannel : public sigslot::has_slots<> {
45 public: 45 public:
46 explicit TransportChannel(const std::string& content_name, int component) 46 explicit TransportChannel(const std::string& content_name, int component)
47 : content_name_(content_name), 47 : content_name_(content_name),
48 component_(component), 48 component_(component),
49 writable_(false), 49 readable_(false), writable_(false), receiving_(false) {}
50 receiving_(false) {}
51 virtual ~TransportChannel() {} 50 virtual ~TransportChannel() {}
52 51
53 // TODO(guoweis) - Make this pure virtual once all subclasses of 52 // TODO(guoweis) - Make this pure virtual once all subclasses of
54 // TransportChannel have this defined. 53 // TransportChannel have this defined.
55 virtual TransportChannelState GetState() const { 54 virtual TransportChannelState GetState() const {
56 return TransportChannelState::STATE_CONNECTING; 55 return TransportChannelState::STATE_CONNECTING;
57 } 56 }
58 57
59 // TODO(mallinath) - Remove this API, as it's no longer useful. 58 // TODO(mallinath) - Remove this API, as it's no longer useful.
60 // Returns the session id of this channel. 59 // Returns the session id of this channel.
61 virtual const std::string SessionId() const { return std::string(); } 60 virtual const std::string SessionId() const { return std::string(); }
62 61
63 const std::string& content_name() const { return content_name_; } 62 const std::string& content_name() const { return content_name_; }
64 int component() const { return component_; } 63 int component() const { return component_; }
65 64
66 // Returns the states of this channel. Each time one of these states changes, 65 // Returns the readable and states of this channel. Each time one of these
67 // a signal is raised. These states are aggregated by the TransportManager. 66 // states changes, a signal is raised. These states are aggregated by the
67 // TransportManager.
68 bool readable() const { return readable_; }
68 bool writable() const { return writable_; } 69 bool writable() const { return writable_; }
69 bool receiving() const { return receiving_; } 70 bool receiving() const { return receiving_; }
71 sigslot::signal1<TransportChannel*> SignalReadableState;
70 sigslot::signal1<TransportChannel*> SignalWritableState; 72 sigslot::signal1<TransportChannel*> SignalWritableState;
71 // Emitted when the TransportChannel's ability to send has changed. 73 // Emitted when the TransportChannel's ability to send has changed.
72 sigslot::signal1<TransportChannel*> SignalReadyToSend; 74 sigslot::signal1<TransportChannel*> SignalReadyToSend;
73 sigslot::signal1<TransportChannel*> SignalReceivingState; 75 sigslot::signal1<TransportChannel*> SignalReceivingState;
74 76
75 // Attempts to send the given packet. The return value is < 0 on failure. 77 // Attempts to send the given packet. The return value is < 0 on failure.
76 // TODO: Remove the default argument once channel code is updated. 78 // TODO: Remove the default argument once channel code is updated.
77 virtual int SendPacket(const char* data, size_t len, 79 virtual int SendPacket(const char* data, size_t len,
78 const rtc::PacketOptions& options, 80 const rtc::PacketOptions& options,
79 int flags = 0) = 0; 81 int flags = 0) = 0;
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 // indicates where and how we are currently sending media. 132 // indicates where and how we are currently sending media.
131 sigslot::signal2<TransportChannel*, const Candidate&> SignalRouteChange; 133 sigslot::signal2<TransportChannel*, const Candidate&> SignalRouteChange;
132 134
133 // Invoked when the channel is being destroyed. 135 // Invoked when the channel is being destroyed.
134 sigslot::signal1<TransportChannel*> SignalDestroyed; 136 sigslot::signal1<TransportChannel*> SignalDestroyed;
135 137
136 // Debugging description of this transport channel. 138 // Debugging description of this transport channel.
137 std::string ToString() const; 139 std::string ToString() const;
138 140
139 protected: 141 protected:
142 // Sets the readable state, signaling if necessary.
143 void set_readable(bool readable);
140 144
141 // Sets the writable state, signaling if necessary. 145 // Sets the writable state, signaling if necessary.
142 void set_writable(bool writable); 146 void set_writable(bool writable);
143 147
144 // Sets the receiving state, signaling if necessary. 148 // Sets the receiving state, signaling if necessary.
145 void set_receiving(bool receiving); 149 void set_receiving(bool receiving);
146 150
147 151
148 private: 152 private:
149 // Used mostly for debugging. 153 // Used mostly for debugging.
150 std::string content_name_; 154 std::string content_name_;
151 int component_; 155 int component_;
156 bool readable_;
152 bool writable_; 157 bool writable_;
153 bool receiving_; 158 bool receiving_;
154 159
155 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannel); 160 RTC_DISALLOW_COPY_AND_ASSIGN(TransportChannel);
156 }; 161 };
157 162
158 } // namespace cricket 163 } // namespace cricket
159 164
160 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNEL_H_ 165 #endif // WEBRTC_P2P_BASE_TRANSPORTCHANNEL_H_
OLDNEW
« no previous file with comments | « webrtc/p2p/base/transport.cc ('k') | webrtc/p2p/base/transportchannel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698