Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 1356103002: Revert of Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (Closed)

Created:
5 years, 3 months ago by tommi
Modified:
5 years, 3 months ago
Reviewers:
pthatcher1, honghaiz3
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (patchset #7 id:340001 of https://codereview.webrtc.org/1351673003/ ) Reason for revert: Broke the Windows build: [226/365] LINK_EMBED cc_perftests.exe FAILED: ninja -t msvc -e environment.x86 -- E:\b\build\goma/gomacc "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\remoting\protocol\remoting_unittests.channel_socket_adapter_unittest.obj.rsp /c ..\..\remoting\protocol\channel_socket_adapter_unittest.cc /Foobj\remoting\protocol\remoting_unittests.channel_socket_adapter_unittest.obj /Fdobj\remoting\remoting_unittests.cc.pdb e:\b\build\slave\win\build\src\remoting\protocol\channel_socket_adapter_unittest.cc(36) : error C3861: 'set_readable': identifier not found ninja: build stopped: subcommand failed. Original issue's description: > Replace readable with receiving where receiving means receiving anything (stun ping, response or data packet). > If a connection does not receive for 30 seconds, it will be deleted. > BUG= > > Committed: https://crrev.com/ae16f8547d3b447f62f6660f13688585c6c3de15 > Cr-Commit-Position: refs/heads/master@{#10001} TBR=pthatcher@webrtc.org,honghaiz@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/275a2f16fd99b0f1eb43fd4ba62541af14e797c0 Cr-Commit-Position: refs/heads/master@{#10002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -156 lines) Patch
M talk/app/webrtc/statscollector.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M talk/app/webrtc/statstypes.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/statstypes.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 4 chunks +20 lines, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 14 chunks +44 lines, -20 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 16 chunks +31 lines, -29 lines 0 comments Download
M webrtc/p2p/base/port.h View 8 chunks +15 lines, -17 lines 0 comments Download
M webrtc/p2p/base/port.cc View 14 chunks +61 lines, -38 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M webrtc/p2p/base/transport.h View 8 chunks +21 lines, -8 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 5 chunks +22 lines, -0 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 4 chunks +9 lines, -4 lines 0 comments Download
M webrtc/p2p/base/transportchannel.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transportchannelproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/transportchannelproxy.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tommi
5 years, 3 months ago (2015-09-21 14:20:17 UTC) #1
Created Revert of Replace readable with receiving where receiving means
receiving anything (stun ping, response or da…

Powered by Google App Engine
This is Rietveld 408576698