Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1355083002: Roll chromium_revision 310ea93..8cf53d6 (349094:351112) (Closed)

Created:
5 years, 3 months ago by kjellander_webrtc
Modified:
5 years, 2 months ago
Reviewers:
Johann, marpan2
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision 310ea93..8cf53d6 (349094:351112) Our perf test suite webrtc_perf_tests timed out, which caused most of the delay landing this (https://crbug.comn/535973 and https://codereview.chromium.org/1370133004). Other problems with executing Android tests also needed to be resolved in order to land this (http://crbug.com/534849). Libvpx has moved from third_party/libvpx to third_party/libvpx_new as of https://codereview.chromium.org/1323333002/ Android GN was blocking this roll due to a problem that ended up being caused by a bug (http://crbug.com/534849). Relevant changes: * src/buildtools: f7310ee..8d89c1b * src/third_party/boringssl/src: 1d128f3..4c60d35 * src/third_party/icu: 6b3ce81..423fc7e * src/third_party/libjpeg_turbo: 631e2dd..e4e7503 * src/third_party/libvpx: ac1772e..70db223 * src/third_party/libyuv: fcacbfb..62c49dc * src/tools/gyp: 5d01a8c..01528c7 * src/tools/swarming_client: 77f720b..6e5d2b2 Details: https://chromium.googlesource.com/chromium/src/+/310ea93..8cf53d6/DEPS Clang version changed 245965:247874 Details: https://chromium.googlesource.com/chromium/src/+/310ea93..8cf53d6/tools/clang/scripts/update.sh BUG=481034, 535973 TBR=marpan@webrtc.org Committed: https://crrev.com/d6024e3c34bf5ebce5624c4dc8930a5b4ae63d36 Cr-Commit-Position: refs/heads/master@{#10101}

Patch Set 1 #

Patch Set 2 : Rename GYP target libvpx to libvpx_new #

Patch Set 3 : Update to 74be507 (#350236) #

Patch Set 4 : Update to 6323fa9e (#350405) #

Patch Set 5 : Update to 2372f17 (#351054) #

Patch Set 6 : Update to 8cf53d6 (#351112) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chromium/.gclient View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M setup_links.py View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355083002/1
5 years, 3 months ago (2015-09-21 05:25:18 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios/builds/9585) ios64_sim on ...
5 years, 3 months ago (2015-09-21 05:26:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355083002/20001
5 years, 3 months ago (2015-09-21 05:38:27 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_gn on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn/builds/5745)
5 years, 3 months ago (2015-09-21 05:45:38 UTC) #8
Johann
libvpx updates lgtm. not sure why win_drmemory_light can't find libvpx.gyp
5 years, 3 months ago (2015-09-21 21:13:34 UTC) #9
Johann
On 2015/09/21 21:13:34, Johann wrote: > libvpx updates lgtm. not sure why win_drmemory_light can't find ...
5 years, 3 months ago (2015-09-22 22:07:19 UTC) #10
kjellander_webrtc
On 2015/09/22 22:07:19, Johann wrote: > On 2015/09/21 21:13:34, Johann wrote: > > libvpx updates ...
5 years, 3 months ago (2015-09-23 04:23:21 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355083002/40001
5 years, 3 months ago (2015-09-23 04:29:03 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_x64_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_dbg/builds/4120)
5 years, 3 months ago (2015-09-23 04:50:56 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355083002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355083002/60001
5 years, 2 months ago (2015-09-25 10:47:18 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_drmemory_light/builds/6807)
5 years, 2 months ago (2015-09-25 11:43:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355083002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355083002/80001
5 years, 2 months ago (2015-09-28 12:22:33 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/8001)
5 years, 2 months ago (2015-09-28 14:29:49 UTC) #25
kjellander_webrtc
*sigh* now this should finally be able to go in after https://codereview.chromium.org/1370133004/ has landed.
5 years, 2 months ago (2015-09-28 19:58:51 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355083002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355083002/100001
5 years, 2 months ago (2015-09-28 19:59:29 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_rel on ...
5 years, 2 months ago (2015-09-28 21:59:51 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355083002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355083002/100001
5 years, 2 months ago (2015-09-29 04:15:21 UTC) #34
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 2 months ago (2015-09-29 04:16:54 UTC) #35
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 04:17:06 UTC) #36
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d6024e3c34bf5ebce5624c4dc8930a5b4ae63d36
Cr-Commit-Position: refs/heads/master@{#10101}

Powered by Google App Engine
This is Rietveld 408576698