Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1354143004: Remove callback_cs_ in ViEEncoder. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove callback_cs_ in ViEEncoder. Instead make callbacks const and set on construction. BUG=webrtc:1695 R=philipel@webrtc.org Committed: https://crrev.com/7083e119e8f39d2ec9e504461c1bb6e0bc6be5ff Cr-Commit-Position: refs/heads/master@{#10017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -124 lines) Patch
M webrtc/video/send_statistics_proxy.h View 3 chunks +2 lines, -8 lines 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M webrtc/video_engine/encoder_state_feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_channel_group.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/video_engine/vie_channel_group.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M webrtc/video_engine/vie_encoder.h View 7 chunks +6 lines, -33 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 10 chunks +24 lines, -57 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pbos-webrtc
PTAL woo!
5 years, 3 months ago (2015-09-22 10:24:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354143004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354143004/1
5 years, 3 months ago (2015-09-22 10:24:49 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_asan on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/9462)
5 years, 3 months ago (2015-09-22 10:39:43 UTC) #5
philipel
On 2015/09/22 10:39:43, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years, 3 months ago (2015-09-22 14:06:20 UTC) #6
philipel
5 years, 3 months ago (2015-09-22 14:06:34 UTC) #7
pbos-webrtc
Committed patchset #1 (id:1) manually as 7083e119e8f39d2ec9e504461c1bb6e0bc6be5ff (presubmit successful).
5 years, 3 months ago (2015-09-22 14:29:06 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 14:29:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7083e119e8f39d2ec9e504461c1bb6e0bc6be5ff
Cr-Commit-Position: refs/heads/master@{#10017}

Powered by Google App Engine
This is Rietveld 408576698