Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1353713002: Remove GICE (again). (Closed)

Created:
5 years, 3 months ago by pthatcher1
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove GICE (again). R=guoweis@webrtc.org Committed: https://crrev.com/7cbd188c5ed7df80bb737bd4ada94422730e2d89 Cr-Commit-Position: refs/heads/master@{#9979}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't double add IceProtocolType #

Patch Set 3 : Undo .gclient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+473 lines, -1776 lines) Patch
M talk/app/webrtc/jsepsessiondescription_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 chunk +1 line, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectionendtoend_unittest.cc View 4 chunks +0 lines, -53 lines 0 comments Download
M talk/app/webrtc/webrtcsdp.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M talk/app/webrtc/webrtcsdp_unittest.cc View 8 chunks +7 lines, -17 lines 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 10 chunks +6 lines, -73 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M talk/session/media/mediasession.h View 1 chunk +0 lines, -19 lines 0 comments Download
M talk/session/media/mediasession.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M webrtc/p2p/base/candidate.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/p2p/base/constants.h View 2 chunks +0 lines, -14 lines 0 comments Download
M webrtc/p2p/base/constants.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 7 chunks +2 lines, -34 lines 0 comments Download
M webrtc/p2p/base/fakesession.h View 5 chunks +1 line, -9 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 15 chunks +73 lines, -162 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 32 chunks +148 lines, -268 lines 0 comments Download
M webrtc/p2p/base/port.h View 4 chunks +1 line, -22 lines 0 comments Download
M webrtc/p2p/base/port.cc View 24 chunks +69 lines, -207 lines 0 comments Download
M webrtc/p2p/base/port_unittest.cc View 31 chunks +68 lines, -372 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/p2p/base/portallocator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M webrtc/p2p/base/portinterface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/session.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/session.cc View 4 chunks +1 line, -8 lines 0 comments Download
M webrtc/p2p/base/transport.h View 7 chunks +1 line, -11 lines 0 comments Download
M webrtc/p2p/base/transport.cc View 8 chunks +1 line, -84 lines 0 comments Download
M webrtc/p2p/base/transport_unittest.cc View 12 chunks +15 lines, -27 lines 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 2 chunks +9 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transportdescription.h View 4 chunks +5 lines, -22 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 4 chunks +5 lines, -38 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory_unittest.cc View 8 chunks +23 lines, -132 lines 0 comments Download
M webrtc/p2p/base/turnport_unittest.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/p2p/client/fakeportallocator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/client/portallocator_unittest.cc View 19 chunks +4 lines, -48 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pthatcher1
https://codereview.webrtc.org/1353713002/diff/1/chromium/.gclient File chromium/.gclient (right): https://codereview.webrtc.org/1353713002/diff/1/chromium/.gclient#newcode13 chromium/.gclient:13: 'src/third_party/deqp/src': None, My client won't sync without this. But ...
5 years, 3 months ago (2015-09-17 07:09:37 UTC) #2
guoweis_webrtc
On 2015/09/17 07:09:37, pthatcher1 wrote: > https://codereview.webrtc.org/1353713002/diff/1/chromium/.gclient > File chromium/.gclient (right): > > https://codereview.webrtc.org/1353713002/diff/1/chromium/.gclient#newcode13 > ...
5 years, 3 months ago (2015-09-17 16:54:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353713002/20001
5 years, 3 months ago (2015-09-18 01:14:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/819)
5 years, 3 months ago (2015-09-18 01:16:50 UTC) #7
pthatcher1
Committed patchset #3 (id:40001) manually as 7cbd188c5ed7df80bb737bd4ada94422730e2d89 (presubmit successful).
5 years, 3 months ago (2015-09-18 01:55:10 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 01:55:12 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7cbd188c5ed7df80bb737bd4ada94422730e2d89
Cr-Commit-Position: refs/heads/master@{#9979}

Powered by Google App Engine
This is Rietveld 408576698