Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1353083003: This relands the conversion tool from RtcEventLog files to RTPdump format. (Closed)

Created:
5 years, 3 months ago by ivoc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

This relands "Tool to convert RtcEventLog files to RtpDump format.", commit 35624c2c3686a2ad40daffe073aa78507b0ef88e. Moved the build target into a section in the gyp file that is conditional on 'include_test==1', as well as on 'enable_protobuf==1'. Original review: https://codereview.webrtc.org/1297653002/ Reverted in be4959535a39262e1508cc4223b78b8db677cb94 BUG=webrtc:4741 TBR=kjellander@webrtc.org,stefan@webrtc.org,henrik.lundin@webrtc.org Committed: https://crrev.com/e1aa5b530d300e562409017766d72a791055c5e0 Cr-Commit-Position: refs/heads/master@{#9990}

Patch Set 1 : Updated version - only webrtc.gyp is changed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -1 line) Patch
M webrtc/test/rtp_file_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
A webrtc/video/rtc_event_log2rtp_dump.cc View 1 chunk +207 lines, -0 lines 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1353083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1353083003/1
5 years, 3 months ago (2015-09-18 12:41:31 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 13:39:28 UTC) #4
ivoc
Committed patchset #1 (id:1) manually as e1aa5b530d300e562409017766d72a791055c5e0 (presubmit successful).
5 years, 3 months ago (2015-09-18 13:41:28 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1aa5b530d300e562409017766d72a791055c5e0 Cr-Commit-Position: refs/heads/master@{#9990}
5 years, 3 months ago (2015-09-18 13:41:30 UTC) #6
kjellander_webrtc
lgtm
5 years, 3 months ago (2015-09-20 17:54:40 UTC) #7
hlundin-webrtc
5 years, 3 months ago (2015-09-21 12:30:41 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698