Issue 1352433002: Reset frame timestamp epoch for new capturers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1352433002: Reset frame timestamp epoch for new capturers. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc

Modified:
5 years, 3 months ago

Reviewers:
stefan-webrtc, pthatcher1, tnakamura-webrtc

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald

Base URL:
https://chromium.googlesource.com/external/webrtc.git@46

Target Ref:
refs/pending/branch-heads/46

Project:
webrtc

Visibility:
Public.

Reset frame timestamp epoch for new capturers. Incoming frames usually have an epoch of time since the capturer was created or similar, not any fixed-time epoch. As such, setting a new capturer resulted in delivering frames with older timestamps which caused these frames to be dropped before encoding. BUG=webrtc:4994 R=stefan@webrtc.org TBR=pthatcher@webrtc.org Review URL: https://codereview.webrtc.org/1345473002 Cr-Commit-Position: refs/heads/master@{#9934} (cherry picked from commit 1cb121dea478a4bb4f88e76cf92719e2853543cf) BUG=chromium:532132 TBR=tnakamura@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/49ee350abb17b050582ee5b76423708522985688

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -8 lines)			Patch
M	talk/media/base/fakevideocapturer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	talk/media/webrtc/webrtcvideoengine2.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	talk/media/webrtc/webrtcvideoengine2_unittest.cc	View	3 chunks	+62 lines, -8 lines	0 comments	Download

Total messages: 1 (0 generated)

pbos-webrtc

5 years, 3 months ago (2015-09-16 12:44:56 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
49ee350abb17b050582ee5b76423708522985688 (presubmit successful).