Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1352423002: Revert of Update build files to use webrtc_overrides in Chromium instead of overrides. (Closed)

Created:
5 years, 3 months ago by Henrik Grunell WebRTC
Modified:
5 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, andresp
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Update build files to use webrtc_overrides in Chromium instead of overrides. (patchset #2 id:20001 of https://codereview.webrtc.org/1354933002/ ) Reason for revert: Breaks FYI bots. ninja: error: '../../third_party/webrtc_overrides/webrtc/base/logging.cc', needed by 'obj/third_party/webrtc_overrides/webrtc/base/rtc_base.logging.o', missing and no known rule to make it Original issue's description: > Update build files to use webrtc_overrides in Chromium instead of overrides. > > This is a part of moving the overrides to Chromium. See bug comment #65 for all steps. > > BUG=chromium:468375 > > Committed: https://crrev.com/baae0a8a6c873ddf812a5687b84638359b2e7e5b > Cr-Commit-Position: refs/heads/master@{#9996} TBR=kjellander@webrtc.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468375 Committed: https://crrev.com/40bf49375426132834589263efd1efbb177ef7b2 Cr-Commit-Position: refs/heads/master@{#9998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M webrtc/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/base/base.gyp View 4 chunks +8 lines, -8 lines 0 comments Download
M webrtc/build/common.gypi View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Henrik Grunell WebRTC
Created Revert of Update build files to use webrtc_overrides in Chromium instead of overrides.
5 years, 3 months ago (2015-09-21 10:29:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352423002/1
5 years, 3 months ago (2015-09-21 10:29:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 10:29:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/40bf49375426132834589263efd1efbb177ef7b2 Cr-Commit-Position: refs/heads/master@{#9998}
5 years, 3 months ago (2015-09-21 10:29:37 UTC) #4
kjellander_webrtc
5 years, 3 months ago (2015-09-21 10:35:53 UTC) #5
Message was sent while issue was closed.
On 2015/09/21 10:29:37, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/40bf49375426132834589263efd1efbb177ef7b2
> Cr-Commit-Position: refs/heads/master@{#9998}

We spoke offline, but FTR: you need to land the Chromium CL so webrtc_overrides
exists in Chromium first. Then this should be able to land without breaking our
roll-bots.

Powered by Google App Engine
This is Rietveld 408576698