Exposing RtpSenders and RtpReceivers from PeerConnection.

talk/app/webrtc/java/src/org/webrtc/RtpReceiver.java

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
  *     this list of conditions and the following disclaimer in the documentation
  *     and/or other materials provided with the distribution.
  *  3. The name of the author may not be used to endorse or promote products
  *     derived from this software without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO
  * EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 package org.webrtc;
 
-public class CallSessionFileRotatingLogSink {
-  static {
-    System.loadLibrary("jingle_peerconnection_so");
+/** Java wrapper for a C++ RtpReceiverInterface. */
+public class RtpReceiver {
+  final long nativeRtpReceiver;
+
+  private MediaStreamTrack cachedTrack;

[pthatcher1, 2015/09/23 14:47:39]

Why not just call it track?

+
+  public RtpReceiver(long nativeRtpReceiver) {
+    this.nativeRtpReceiver = nativeRtpReceiver;
+    long track = nativeTrack(nativeRtpReceiver);
+    cachedTrack = new MediaStreamTrack(track);

[pthatcher1, 2015/09/23 14:47:39]

Please use the "this." prefix in both place or neither.

   }
 
-  private long nativeSink;
-
-  public static byte[] getLogData(String dirPath) {
-    return nativeGetLogData(dirPath);
-  }
-
-  public CallSessionFileRotatingLogSink(
-      String dirPath, int maxFileSize, Logging.Severity severity) {
-    nativeSink = nativeAddSink(dirPath, maxFileSize, severity.ordinal());
+  public MediaStreamTrack track() {
+    return cachedTrack;
   }
 
   public void dispose() {
-    if (nativeSink != 0) {
-      nativeDeleteSink(nativeSink);
-      nativeSink = 0;
+    free(nativeRtpReceiver);
+    if (cachedTrack != null) {
+      cachedTrack.dispose();
     }
   }
 
-  private static native long nativeAddSink(
-      String dirPath, int maxFileSize, int severity);
-  private static native void nativeDeleteSink(long nativeSink);
-  private static native byte[] nativeGetLogData(String dirPath);
-}
+  // This should increment the reference count of the track, with the assumption
+  // that a MediaStreamTrack will be created which will release it.
+  private static native long nativeTrack(long nativeRtpReceiver);
+
+  private static native void free(long nativeRtpReceiver);
+};