Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: webrtc/video/screenshare_loopback.cc

Issue 1351693005: Read the number of TLs for VP9 too + cleanup (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase master and reordering of params Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/screenshare_loopback.cc
diff --git a/webrtc/video/screenshare_loopback.cc b/webrtc/video/screenshare_loopback.cc
index 9897783eb9ddf8ff59d644722b624943b403978c..a8ce1d36666f8b4b8960e2190b2df6b524d68f9d 100644
--- a/webrtc/video/screenshare_loopback.cc
+++ b/webrtc/video/screenshare_loopback.cc
@@ -83,6 +83,11 @@ size_t TLDiscardThreshold() {
return static_cast<size_t>(FLAGS_tl_discard_threshold);
}
+DEFINE_bool(disable_wrapper_frame_dropper,
+ false,
+ "Disable FrameDropper in the wrapper. "
stefan-webrtc 2015/10/01 08:45:59 Generic bitrate frame dropper?
ivica 2015/10/01 09:29:20 Renamed. Not sure how to name the flag though. Ren
stefan-webrtc 2015/10/01 09:58:04 remove "in the wrapper". No one using this applica
ivica 2015/10/01 11:17:51 Done.
+ "Does not affect drop on capture or PacedSender.");
+
DEFINE_int32(min_transmit_bitrate, 400, "Min transmit bitrate incl. padding.");
int MinTransmitBitrateKbps() {
return FLAGS_min_transmit_bitrate;
@@ -169,7 +174,7 @@ void Loopback() {
flags::MaxBitrateKbps() * 1000, flags::Codec(),
flags::NumTemporalLayers(), flags::MinTransmitBitrateKbps() * 1000,
call_bitrate_config, flags::TLDiscardThreshold(),
- flags::FLAGS_send_side_bwe},
+ flags::FLAGS_send_side_bwe, flags::FLAGS_disable_wrapper_frame_dropper},
{}, // Video specific.
{true, flags::SlideChangeInterval(), flags::ScrollDuration()},
{"screenshare", 0.0, 0.0, flags::DurationSecs(), flags::OutputFilename()},

Powered by Google App Engine
This is Rietveld 408576698