Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Side by Side Diff: webrtc/video/screenshare_loopback.cc

Issue 1351693005: Read the number of TLs for VP9 too + cleanup (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase master Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 } 76 }
77 77
78 DEFINE_int32( 78 DEFINE_int32(
79 tl_discard_threshold, 79 tl_discard_threshold,
80 0, 80 0,
81 "Discard TLs with id greater or equal the threshold. 0 to disable."); 81 "Discard TLs with id greater or equal the threshold. 0 to disable.");
82 size_t TLDiscardThreshold() { 82 size_t TLDiscardThreshold() {
83 return static_cast<size_t>(FLAGS_tl_discard_threshold); 83 return static_cast<size_t>(FLAGS_tl_discard_threshold);
84 } 84 }
85 85
86 DEFINE_bool(disable_frame_dropper,
87 false,
88 "Disable generic bitrate frame dropper. "
89 "Does not affect drop on capture or PacedSender.");
90
86 DEFINE_int32(min_transmit_bitrate, 400, "Min transmit bitrate incl. padding."); 91 DEFINE_int32(min_transmit_bitrate, 400, "Min transmit bitrate incl. padding.");
87 int MinTransmitBitrateKbps() { 92 int MinTransmitBitrateKbps() {
88 return FLAGS_min_transmit_bitrate; 93 return FLAGS_min_transmit_bitrate;
89 } 94 }
90 95
91 DEFINE_string(codec, "VP8", "Video codec to use."); 96 DEFINE_string(codec, "VP8", "Video codec to use.");
92 std::string Codec() { 97 std::string Codec() {
93 return static_cast<std::string>(FLAGS_codec); 98 return static_cast<std::string>(FLAGS_codec);
94 } 99 }
95 100
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000; 167 call_bitrate_config.min_bitrate_bps = flags::MinBitrateKbps() * 1000;
163 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000; 168 call_bitrate_config.start_bitrate_bps = flags::StartBitrateKbps() * 1000;
164 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000; 169 call_bitrate_config.max_bitrate_bps = flags::MaxBitrateKbps() * 1000;
165 170
166 VideoQualityTest::Params params{ 171 VideoQualityTest::Params params{
167 {flags::Width(), flags::Height(), flags::Fps(), 172 {flags::Width(), flags::Height(), flags::Fps(),
168 flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000, 173 flags::MinBitrateKbps() * 1000, flags::TargetBitrateKbps() * 1000,
169 flags::MaxBitrateKbps() * 1000, flags::Codec(), 174 flags::MaxBitrateKbps() * 1000, flags::Codec(),
170 flags::NumTemporalLayers(), flags::MinTransmitBitrateKbps() * 1000, 175 flags::NumTemporalLayers(), flags::MinTransmitBitrateKbps() * 1000,
171 call_bitrate_config, flags::TLDiscardThreshold(), 176 call_bitrate_config, flags::TLDiscardThreshold(),
172 flags::FLAGS_send_side_bwe}, 177 flags::FLAGS_send_side_bwe, flags::FLAGS_disable_frame_dropper},
173 {}, // Video specific. 178 {}, // Video specific.
174 {true, flags::SlideChangeInterval(), flags::ScrollDuration()}, 179 {true, flags::SlideChangeInterval(), flags::ScrollDuration()},
175 {"screenshare", 0.0, 0.0, flags::DurationSecs(), flags::OutputFilename()}, 180 {"screenshare", 0.0, 0.0, flags::DurationSecs(), flags::OutputFilename()},
176 pipe_config, 181 pipe_config,
177 flags::FLAGS_logs}; 182 flags::FLAGS_logs};
178 183
179 VideoQualityTest test; 184 VideoQualityTest test;
180 if (flags::OutputFilename().empty()) 185 if (flags::OutputFilename().empty())
181 test.RunWithVideoRenderer(params); 186 test.RunWithVideoRenderer(params);
182 else 187 else
183 test.RunWithAnalyzer(params); 188 test.RunWithAnalyzer(params);
184 } 189 }
185 } // namespace webrtc 190 } // namespace webrtc
186 191
187 int main(int argc, char* argv[]) { 192 int main(int argc, char* argv[]) {
188 ::testing::InitGoogleTest(&argc, argv); 193 ::testing::InitGoogleTest(&argc, argv);
189 google::ParseCommandLineFlags(&argc, &argv, true); 194 google::ParseCommandLineFlags(&argc, &argv, true);
190 webrtc::test::InitFieldTrialsFromString( 195 webrtc::test::InitFieldTrialsFromString(
191 webrtc::flags::FLAGS_force_fieldtrials); 196 webrtc::flags::FLAGS_force_fieldtrials);
192 webrtc::test::RunTest(webrtc::Loopback); 197 webrtc::test::RunTest(webrtc::Loopback);
193 return 0; 198 return 0;
194 } 199 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698