Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: webrtc/p2p/base/transportchannel.h

Issue 1351673003: Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Resync, rebase, and address comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/transportchannel.h
diff --git a/webrtc/p2p/base/transportchannel.h b/webrtc/p2p/base/transportchannel.h
index 5b13e68992361aec311e7d6b6d0aa29f92e597f9..f5ad904a91365baa377c15191f17c5548c73d009 100644
--- a/webrtc/p2p/base/transportchannel.h
+++ b/webrtc/p2p/base/transportchannel.h
@@ -51,7 +51,6 @@ class TransportChannel : public sigslot::has_slots<> {
explicit TransportChannel(const std::string& transport_name, int component)
: transport_name_(transport_name),
component_(component),
- readable_(false),
writable_(false),
receiving_(false) {}
virtual ~TransportChannel() {}
@@ -69,13 +68,10 @@ class TransportChannel : public sigslot::has_slots<> {
const std::string& transport_name() const { return transport_name_; }
int component() const { return component_; }
- // Returns the readable and states of this channel. Each time one of these
- // states changes, a signal is raised. These states are aggregated by the
- // TransportManager.
- bool readable() const { return readable_; }
+ // Returns the states of this channel. Each time one of these states changes,
+ // a signal is raised. These states are aggregated by the TransportManager.
bool writable() const { return writable_; }
bool receiving() const { return receiving_; }
- sigslot::signal1<TransportChannel*> SignalReadableState;
sigslot::signal1<TransportChannel*> SignalWritableState;
// Emitted when the TransportChannel's ability to send has changed.
sigslot::signal1<TransportChannel*> SignalReadyToSend;
@@ -146,8 +142,6 @@ class TransportChannel : public sigslot::has_slots<> {
std::string ToString() const;
protected:
- // Sets the readable state, signaling if necessary.
- void set_readable(bool readable);
// Sets the writable state, signaling if necessary.
void set_writable(bool writable);
@@ -159,7 +153,6 @@ class TransportChannel : public sigslot::has_slots<> {
// Used mostly for debugging.
std::string transport_name_;
int component_;
- bool readable_;
bool writable_;
bool receiving_;

Powered by Google App Engine
This is Rietveld 408576698