webrtc/p2p/base/dtlstransportchannel_unittest.cc - Issue 1351673003: Replace readable with receiving where receiving means receiving anything (stun ping, response or da…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/dtlstransportchannel_unittest.cc

Issue 1351673003: Replace readable with receiving where receiving means receiving anything (stun ping, response or da… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/p2p/base/dtlstransportchannel_unittest.cc

diff --git a/webrtc/p2p/base/dtlstransportchannel_unittest.cc b/webrtc/p2p/base/dtlstransportchannel_unittest.cc

index 34aa651af7ee6c69e2fe910bede4db874a6ba728..26b67dbf0cf0b7c1bca40e3f4027f211142e1111 100644

--- a/webrtc/p2p/base/dtlstransportchannel_unittest.cc

+++ b/webrtc/p2p/base/dtlstransportchannel_unittest.cc

@@ -199,7 +199,7 @@ class DtlsTestClient : public sigslot::has_slots<> {

return true;

}

- bool writable() const { return transport_->writable(); }

+ bool writable() const { return transport_->any_channels_writable(); }

pthatcher1 2015/09/18 17:56:54 Shouldn't this be all_channels_writable()? And

honghaiz3 2015/09/18 21:39:30 I tried to removed it. But to be safe, I revert i

void CheckRole(rtc::SSLRole role) {

if (role == rtc::SSL_CLIENT) {

« no previous file with comments | « webrtc/p2p/base/dtlstransportchannel.cc ('k') | webrtc/p2p/base/p2ptransportchannel.h » ('j') | webrtc/p2p/base/p2ptransportchannel.cc » ('J')