Add delay metric (includes network delay (rtt/2) + jitter delay + decode time +

Add delay metric (includes network delay (rtt/2) + jitter delay + decode time + render delay):
- "WebRTC.Video.OnewayDelayInMs"

BUG=chromium:512752
Committed: https://crrev.com/13c433c299822c6f2aefef46fa6aca52ec46ea49
Cr-Commit-Position: refs/heads/master@{#10180}

[åsapersson, 2015-09-22 10:40:47]

asapersson@webrtc.org changed reviewers:
+ mflodman@webrtc.org, pbos@webrtc.org, stefan@webrtc.org

[pbos-webrtc, 2015-09-24 16:04:35]

lgtm

[stefan-webrtc, 2015-09-28 15:20:42]

https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
File webrtc/video/receive_statistics_proxy.cc (right):

https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
webrtc/video/receive_statistics_proxy.cc:96: delay_counter_.Add(target_delay_ms
+ rtt_ms / 2);
Why are we adding rtt/2? Should at least be explained in the CL description.

[mflodman, 2015-10-02 09:25:01]

See Stefan's comment, then LGTM.

[åsapersson, 2015-10-05 13:26:00]

https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
File webrtc/video/receive_statistics_proxy.cc (right):

https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
webrtc/video/receive_statistics_proxy.cc:96: delay_counter_.Add(target_delay_ms
+ rtt_ms / 2);
On 2015/09/28 15:20:42, stefan-webrtc (holmer) wrote:
> Why are we adding rtt/2? Should at least be explained in the CL description.

Added comment and updated CL description.

[stefan-webrtc, 2015-10-06 08:28:29]

On 2015/10/05 13:26:00, åsapersson wrote:
>
https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
> File webrtc/video/receive_statistics_proxy.cc (right):
> 
>
https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
> webrtc/video/receive_statistics_proxy.cc:96:
delay_counter_.Add(target_delay_ms
> + rtt_ms / 2);
> On 2015/09/28 15:20:42, stefan-webrtc (holmer) wrote:
> > Why are we adding rtt/2? Should at least be explained in the CL description.
> 
> Added comment and updated CL description.

Should we call it something else than ReceiveSideDelayInMs? From offline
discussion it seems like it is supposed to be an estimate of the end-to-end
delay? It is confusing to me that the receive-side delay would include half an
RTT.

[åsapersson, 2015-10-06 08:51:25]

On 2015/10/06 08:28:29, stefan-webrtc (holmer) wrote:
> On 2015/10/05 13:26:00, åsapersson wrote:
> >
>
https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
> > File webrtc/video/receive_statistics_proxy.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
> > webrtc/video/receive_statistics_proxy.cc:96:
> delay_counter_.Add(target_delay_ms
> > + rtt_ms / 2);
> > On 2015/09/28 15:20:42, stefan-webrtc (holmer) wrote:
> > > Why are we adding rtt/2? Should at least be explained in the CL
description.
> > 
> > Added comment and updated CL description.
> 
> Should we call it something else than ReceiveSideDelayInMs? From offline
> discussion it seems like it is supposed to be an estimate of the end-to-end
> delay? It is confusing to me that the receive-side delay would include half an
> RTT.

How about OnewayDelayInMs instead?

[stefan-webrtc, 2015-10-06 08:55:57]

On 2015/10/06 08:51:25, åsapersson wrote:
> On 2015/10/06 08:28:29, stefan-webrtc (holmer) wrote:
> > On 2015/10/05 13:26:00, åsapersson wrote:
> > >
> >
>
https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
> > > File webrtc/video/receive_statistics_proxy.cc (right):
> > > 
> > >
> >
>
https://codereview.webrtc.org/1351403008/diff/1/webrtc/video/receive_statisti...
> > > webrtc/video/receive_statistics_proxy.cc:96:
> > delay_counter_.Add(target_delay_ms
> > > + rtt_ms / 2);
> > > On 2015/09/28 15:20:42, stefan-webrtc (holmer) wrote:
> > > > Why are we adding rtt/2? Should at least be explained in the CL
> description.
> > > 
> > > Added comment and updated CL description.
> > 
> > Should we call it something else than ReceiveSideDelayInMs? From offline
> > discussion it seems like it is supposed to be an estimate of the end-to-end
> > delay? It is confusing to me that the receive-side delay would include half
an
> > RTT.
> 
> How about OnewayDelayInMs instead?

That's ok with me.

lgtm

[åsapersson, 2015-10-06 09:29:49]

The CQ bit was checked by asapersson@webrtc.org

[åsapersson, 2015-10-06 09:29:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
mflodman@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1351403008/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2015-10-06 09:30:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351403008/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351403008/80001

[commit-bot: I haz the power, 2015-10-06 11:08:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-06 11:08:31]

Patchset 5 (id:??) landed as
https://crrev.com/13c433c299822c6f2aefef46fa6aca52ec46ea49
Cr-Commit-Position: refs/heads/master@{#10180}