talk/app/webrtc/java/jni/androidvideocapturer_jni.cc - Issue 1350863002: VideoCapturerAndroid: Fix threading issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/java/jni/androidvideocapturer_jni.cc

Issue 1350863002: VideoCapturerAndroid: Fix threading issues (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/java/jni/androidvideocapturer_jni.cc

diff --git a/talk/app/webrtc/java/jni/androidvideocapturer_jni.cc b/talk/app/webrtc/java/jni/androidvideocapturer_jni.cc

index 43a60c3cecd9b9d8ff73ecfe407100ed1a927c71..c6bc7c95367452e812769f2feb542d7f9c697e30 100644

--- a/talk/app/webrtc/java/jni/androidvideocapturer_jni.cc

+++ b/talk/app/webrtc/java/jni/androidvideocapturer_jni.cc

@@ -88,6 +88,10 @@ bool AndroidVideoCapturerJni::Init(jstring device_name) {

AndroidVideoCapturerJni::~AndroidVideoCapturerJni() {

LOG(LS_INFO) << "AndroidVideoCapturerJni dtor";

+ jni()->CallVoidMethod(

+ *j_capturer_global_,

+ GetMethodID(jni(), *j_video_capturer_class_, "release", "()V"));

+ CHECK_EXCEPTION(jni()) << "error during VideoCapturerAndroid.release()";

}

void AndroidVideoCapturerJni::Start(int width, int height, int framerate,