Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 1350663002: VideoCapturerAndroid: Add test for making calls on stopped camera (Closed)

Created:
5 years, 3 months ago by magjed_webrtc
Modified:
5 years, 3 months ago
Reviewers:
phoglund, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Add test for making calls on stopped camera BUG=webrtc:4978 R=perkj@webrtc.org Committed: https://crrev.com/ea70d77fd54fa9bd0401220bfbca585c575f7eff Cr-Commit-Position: refs/heads/master@{#10062}

Patch Set 1 #

Patch Set 2 : Rebase and also test onOutputFormatRequest() and changeCaptureFormat() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M talk/app/webrtc/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
magjed_webrtc
perkj - Please take a look. This is a regression test for bug 4978. I ...
5 years, 3 months ago (2015-09-16 08:39:40 UTC) #2
perkj_webrtc
lgtm
5 years, 3 months ago (2015-09-16 14:41:16 UTC) #3
magjed_webrtc
perkj - Please take another look. phoglund - FYI.
5 years, 3 months ago (2015-09-24 14:39:36 UTC) #5
perkj_webrtc
still lgtm
5 years, 3 months ago (2015-09-24 18:32:46 UTC) #6
magjed_webrtc
Committed patchset #2 (id:20001) manually as ea70d77fd54fa9bd0401220bfbca585c575f7eff (presubmit successful).
5 years, 3 months ago (2015-09-24 19:41:12 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 19:41:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea70d77fd54fa9bd0401220bfbca585c575f7eff
Cr-Commit-Position: refs/heads/master@{#10062}

Powered by Google App Engine
This is Rietveld 408576698