Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m

Issue 1350523003: TransportController refactoring. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing Mac test. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | talk/app/webrtc/objctests/RTCPeerConnectionTest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m
diff --git a/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m b/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m
index 5070b789b899bcec92fa0e9a1854824eabd26367..daebc9523dbe0679a7d5717033662a66a6e2a5bc 100644
--- a/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m
+++ b/talk/app/webrtc/objctests/RTCPeerConnectionSyncObserver.m
@@ -196,8 +196,11 @@
if (newState == RTCICEGatheringGathering) {
return;
}
+ NSAssert([_expectedICEGatheringChanges count] > 0,
+ @"Unexpected ICE gathering state change");
int expectedState = [self popFirstElementAsInt:_expectedICEGatheringChanges];
- NSAssert(expectedState == (int)newState, @"Empty expectation array");
+ NSAssert(expectedState == (int)newState,
+ @"ICE gathering state should match expectation");
}
- (void)peerConnection:(RTCPeerConnection*)peerConnection
@@ -205,8 +208,11 @@
// See TODO(fischman) in RTCPeerConnectionTest.mm about Completed.
if (newState == RTCICEConnectionCompleted)
return;
+ NSAssert([_expectedICEConnectionChanges count] > 0,
+ @"Unexpected ICE connection state change");
int expectedState = [self popFirstElementAsInt:_expectedICEConnectionChanges];
- NSAssert(expectedState == (int)newState, @"Empty expectation array");
+ NSAssert(expectedState == (int)newState,
+ @"ICE connection state should match expectation");
}
- (void)peerConnection:(RTCPeerConnection*)peerConnection
« no previous file with comments | « no previous file | talk/app/webrtc/objctests/RTCPeerConnectionTest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698