webrtc/video_engine/vie_channel.h - Issue 1350163005: Avoid circular dependency rtp_rtcp <-> paced_sender

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video_engine/vie_channel.h

Issue 1350163005: Avoid circular dependency rtp_rtcp <-> paced_sender (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Add explicit rtp_rtcp -> pacing dep. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/video_engine/vie_channel.h

diff --git a/webrtc/video_engine/vie_channel.h b/webrtc/video_engine/vie_channel.h

index fc015926fa46d5f23744b41c41aac3583bd0a232..1d308f16dd45ce3799d323745ab4ef377c106f55 100644

--- a/webrtc/video_engine/vie_channel.h

+++ b/webrtc/video_engine/vie_channel.h

@@ -298,8 +298,8 @@ class ViEChannel : public VCMFrameTypeCallback,

RtcpRttStats* rtt_stats,

RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer,

RemoteBitrateEstimator* remote_bitrate_estimator,

- PacedSender* paced_sender,

- PacketRouter* packet_router,

+ RtpPacketSender* paced_sender,

+ SequenceNumberAllocator* sequence_number_allocator,

stefan-webrtc 2015/09/21 13:48:14 Rename here as well

sprang_webrtc 2015/09/21 14:02:34 Done.

BitrateStatisticsObserver* send_bitrate_observer,

FrameCountObserver* send_frame_count_observer,

SendSideDelayObserver* send_side_delay_observer,

« webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h ('K') | « webrtc/video/webrtc_video.gypi ('k') | webrtc/video_engine/vie_channel.cc » ('j') | no next file with comments »