Remove overridden basictypes.h.

Remove overridden basictypes.h.

* Use (u)intxx_t for (u)intxx typedefs for all platforms.
* Always include stdint.h.
* Add RTC_ prefix to ARCH_XXX macros.

Chromium did the (u)intxx_t change in
https://codereview.chromium.org/117323010 and
https://codereview.chromium.org/639293007

BUG=chromium:468375
TBR=perkj@webrtc.org (for trivial talk/* changes)
NOTRY=true
NOPRESUBMIT=true

Committed: https://crrev.com/71df77bba01c86bc3bd359a61573698ea064f35f
Cr-Commit-Position: refs/heads/master@{#9983}

[Henrik Grunell WebRTC, 2015-09-17 16:44:56]

henrikg@webrtc.org changed reviewers:
+ andrew@webrtc.org, tommi@webrtc.org

[Henrik Grunell WebRTC, 2015-09-17 16:46:20]

Do we need to support MSC ver < 1600 (2010 I think)? Chromium includes stdint.h
always, see links in description. I think we could do that as well.

[Andrew MacDonald, 2015-09-17 17:03:14]

lgtm % minor changes

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h
File webrtc/base/basictypes.h (right):

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:14: #include <stddef.h>  // for NULL, size_t
Needed?

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:21: #include "webrtc/base/constructormagic.h"
This doesn't appear to be needed.

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:45: #if !defined(RTC_ARCH_CPU_BIG_ENDIAN) &&
!defined(RTC_ARCH_CPU_LITTLE_ENDIAN)
Just curious why you chose to rename these ARCH_CPU macros in this CL but not
the others in this file?

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:68:
(reinterpret_cast<uint8*>(((reinterpret_cast<uintptr_t>(p) + \
uint8_t

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:74: // it is leaked so that its destructors are not
called at exit.
Sorry, would you mind rewriting this?
Remove "(static T;)".

"so that it is leaked" -> "that gets leaked"

[Andrew MacDonald, 2015-09-17 17:03:34]

andrew@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[Andrew MacDonald, 2015-09-17 17:04:14]

On 2015/09/17 16:46:20, Henrik Grunell (webrtc) wrote:
> Do we need to support MSC ver < 1600 (2010 I think)? Chromium includes
stdint.h
> always, see links in description. I think we could do that as well.

I don't think we support pre-2010. Added kjellander to confirm.

[Henrik Grunell WebRTC, 2015-09-18 07:27:23]

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h
File webrtc/base/basictypes.h (right):

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:14: #include <stddef.h>  // for NULL, size_t
On 2015/09/17 17:03:14, Andrew MacDonald wrote:
> Needed?

It seems that we rely on that it's here. We include basictypes.h only at many
places were e.g. size_t is used. (Chromium does the same fwiw.) I think that's
fine.

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:21: #include "webrtc/base/constructormagic.h"
On 2015/09/17 17:03:13, Andrew MacDonald wrote:
> This doesn't appear to be needed.

Right, removed.

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:45: #if !defined(RTC_ARCH_CPU_BIG_ENDIAN) &&
!defined(RTC_ARCH_CPU_LITTLE_ENDIAN)
On 2015/09/17 17:03:13, Andrew MacDonald wrote:
> Just curious why you chose to rename these ARCH_CPU macros in this CL but not
> the others in this file?

Well, only this one is defined in Chromium so it clashes. But maybe it's more
consistent to rename all. I'm fine with either. (I can do that in a follow-up if
this lands today.)

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:68:
(reinterpret_cast<uint8*>(((reinterpret_cast<uintptr_t>(p) + \
On 2015/09/17 17:03:14, Andrew MacDonald wrote:
> uint8_t

Done.

https://codereview.webrtc.org/1349213003/diff/40001/webrtc/base/basictypes.h#...
webrtc/base/basictypes.h:74: // it is leaked so that its destructors are not
called at exit.
On 2015/09/17 17:03:13, Andrew MacDonald wrote:
> Sorry, would you mind rewriting this?
> Remove "(static T;)".
> 
> "so that it is leaked" -> "that gets leaked" 

Absolutely. Done.

[kjellander_webrtc, 2015-09-18 07:34:15]

On 2015/09/17 16:46:20, Henrik Grunell (webrtc) wrote:
> Do we need to support MSC ver < 1600 (2010 I think)? Chromium includes
stdint.h
> always, see links in description. I think we could do that as well.

MSC VER 1600 = 2010 yes
(http://stackoverflow.com/questions/70013/how-to-detect-if-im-compiling-code-w...).
We don't need to support it since Chromium isn't, unless there's a good reason.
Our generic policy is to follow Chromium, so I suggest we do that here too.

[Henrik Grunell WebRTC, 2015-09-18 07:36:44]

On 2015/09/18 07:34:15, kjellander (webrtc) wrote:
> On 2015/09/17 16:46:20, Henrik Grunell (webrtc) wrote:
> > Do we need to support MSC ver < 1600 (2010 I think)? Chromium includes
> stdint.h
> > always, see links in description. I think we could do that as well.
> 
> MSC VER 1600 = 2010 yes
>
(http://stackoverflow.com/questions/70013/how-to-detect-if-im-compiling-code-w...).
> We don't need to support it since Chromium isn't, unless there's a good
reason.
> Our generic policy is to follow Chromium, so I suggest we do that here too.

OK. I'll land this then.

[Henrik Grunell WebRTC, 2015-09-18 08:18:11]

The CQ bit was checked by henrikg@webrtc.org

[Henrik Grunell WebRTC, 2015-09-18 08:18:11]

The patchset sent to the CQ was uploaded after l-g-t-m from andrew@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1349213003/#ps80001 (title:
"Added missing include for Win.")

[commit-bot: I haz the power, 2015-09-18 08:18:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349213003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349213003/80001

[commit-bot: I haz the power, 2015-09-18 08:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 08:20:06]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/821)

[Henrik Grunell WebRTC, 2015-09-18 08:26:25]

henrikg@webrtc.org changed reviewers:
+ perkj@webrtc.org

[Henrik Grunell WebRTC, 2015-09-18 08:28:26]

Per, review talk/* (trivial).

[Henrik Grunell WebRTC, 2015-09-18 08:28:32]

The CQ bit was checked by henrikg@webrtc.org

[commit-bot: I haz the power, 2015-09-18 08:28:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349213003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349213003/80001

[commit-bot: I haz the power, 2015-09-18 08:30:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-18 08:30:20]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/825)

[Henrik Grunell WebRTC, 2015-09-18 08:48:18]

The CQ bit was checked by henrikg@webrtc.org

[commit-bot: I haz the power, 2015-09-18 08:48:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1349213003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1349213003/80001

[commit-bot: I haz the power, 2015-09-18 08:48:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-18 08:48:45]

Patchset 5 (id:??) landed as
https://crrev.com/71df77bba01c86bc3bd359a61573698ea064f35f
Cr-Commit-Position: refs/heads/master@{#9983}