Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: webrtc/modules/audio_processing/debug.proto

Issue 1348903004: Adding APM configuration in AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: unmerge a wrong change Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/debug.proto
diff --git a/webrtc/modules/audio_processing/debug.proto b/webrtc/modules/audio_processing/debug.proto
index dce2f7920930452f7a512d9bda2f3679893cddc2..a68b97663f80fc2aa8da4f0153caa1d602ee63df 100644
--- a/webrtc/modules/audio_processing/debug.proto
+++ b/webrtc/modules/audio_processing/debug.proto
@@ -2,6 +2,8 @@ syntax = "proto2";
option optimize_for = LITE_RUNTIME;
package webrtc.audioproc;
+// Contains the format of input/output/reverse audio. An Init message is added
+// when any of the fields is changed.
Andrew MacDonald 2015/10/02 19:04:01 s/is changed/are changed
message Init {
optional int32 sample_rate = 1;
optional int32 device_sample_rate = 2 [deprecated=true];
@@ -39,11 +41,40 @@ message Stream {
repeated bytes output_channel = 8;
}
+// Contains the configurations of various APM component. A Config message is
+// added when any of the fields is changed.
+message Config {
+ // Next field number 17.
+ // Acoustic echo canceler.
+ optional bool aec_enabled = 1;
+ optional bool aec_delay_agnostic_enabled = 2;
+ optional bool aec_drift_compensation_enabled = 3;
+ optional bool aec_extended_filter_enabled = 4;
+ optional int32 aec_suppression_level = 5;
+ // Mobile AEC.
+ optional bool aecm_enabled = 6;
+ optional bool aecm_comfort_noise_enabled = 7;
+ optional int32 aecm_routing_mode = 8;
+ // Automatic gain controller.
+ optional bool agc_enabled = 9;
+ optional bool agc_experiment_enabled = 10;
Andrew MacDonald 2015/10/02 19:04:02 Similarly, noise_robust_agc_enabled. Or something
turajs 2015/10/02 19:16:36 I'm normally bad with naming. Don't have a better
aluebs-webrtc 2015/10/02 19:16:37 I like your suggestion.
minyue-webrtc 2015/10/02 19:59:59 Thanks for your comments. I'd take Andrew's sugges
Andrew MacDonald 2015/10/02 21:41:56 I get why you want to prefix with agc for consiste
+ optional int32 agc_mode = 11;
+ optional bool agc_limiter_enabled = 12;
+ // High pass filter.
+ optional bool hpf_enabled = 13;
+ // Noise suppression.
+ optional bool ns_enabled = 14;
+ optional bool ns_experiment_enabled = 15;
Andrew MacDonald 2015/10/02 19:04:01 Could you instead call this transient_suppression_
minyue-webrtc 2015/10/02 19:59:59 Nice, I'd even put it at the end as a parallel to
+ optional int32 ns_level = 16;
+}
+
message Event {
enum Type {
INIT = 0;
REVERSE_STREAM = 1;
STREAM = 2;
+ CONFIG = 3;
+ UNKNOWN_EVENT = 4;
}
required Type type = 1;
@@ -51,4 +82,5 @@ message Event {
optional Init init = 2;
optional ReverseStream reverse_stream = 3;
optional Stream stream = 4;
+ optional Config config = 5;
}
« no previous file with comments | « webrtc/modules/audio_processing/audio_processing_impl.cc ('k') | webrtc/modules/audio_processing/echo_cancellation_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698