Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: webrtc/modules/audio_processing/debug.proto

Issue 1348903004: Adding APM configuration in AEC dump. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: renaming two fields Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 syntax = "proto2"; 1 syntax = "proto2";
2 option optimize_for = LITE_RUNTIME; 2 option optimize_for = LITE_RUNTIME;
3 package webrtc.audioproc; 3 package webrtc.audioproc;
4 4
5 // Contains the format of input/output/reverse audio. An Init message is added
6 // when any of the fields are changed.
5 message Init { 7 message Init {
6 optional int32 sample_rate = 1; 8 optional int32 sample_rate = 1;
7 optional int32 device_sample_rate = 2 [deprecated=true]; 9 optional int32 device_sample_rate = 2 [deprecated=true];
8 optional int32 num_input_channels = 3; 10 optional int32 num_input_channels = 3;
9 optional int32 num_output_channels = 4; 11 optional int32 num_output_channels = 4;
10 optional int32 num_reverse_channels = 5; 12 optional int32 num_reverse_channels = 5;
11 optional int32 reverse_sample_rate = 6; 13 optional int32 reverse_sample_rate = 6;
12 optional int32 output_sample_rate = 7; 14 optional int32 output_sample_rate = 7;
13 } 15 }
14 16
(...skipping 17 matching lines...) Expand all
32 optional sint32 drift = 4; 34 optional sint32 drift = 4;
33 optional int32 level = 5; 35 optional int32 level = 5;
34 optional bool keypress = 6; 36 optional bool keypress = 6;
35 37
36 // float deinterleaved data, where each repeated element points to a single 38 // float deinterleaved data, where each repeated element points to a single
37 // channel buffer of data. 39 // channel buffer of data.
38 repeated bytes input_channel = 7; 40 repeated bytes input_channel = 7;
39 repeated bytes output_channel = 8; 41 repeated bytes output_channel = 8;
40 } 42 }
41 43
44 // Contains the configurations of various APM component. A Config message is
45 // added when any of the fields is changed.
Andrew MacDonald 2015/10/02 21:46:04 s/is/are
minyue-webrtc 2015/10/02 21:57:34 oh, thanks. I did not realize that I had made a si
46 message Config {
47 // Next field number 17.
48 // Acoustic echo canceler.
49 optional bool aec_enabled = 1;
50 optional bool aec_delay_agnostic_enabled = 2;
51 optional bool aec_drift_compensation_enabled = 3;
52 optional bool aec_extended_filter_enabled = 4;
53 optional int32 aec_suppression_level = 5;
54 // Mobile AEC.
55 optional bool aecm_enabled = 6;
56 optional bool aecm_comfort_noise_enabled = 7;
57 optional int32 aecm_routing_mode = 8;
58 // Automatic gain controller.
59 optional bool agc_enabled = 9;
60 optional bool agc_noise_robust_enabled = 10;
61 optional int32 agc_mode = 11;
62 optional bool agc_limiter_enabled = 12;
63 // High pass filter.
64 optional bool hpf_enabled = 13;
65 // Noise suppression.
66 optional bool ns_enabled = 14;
67 optional int32 ns_level = 15;
68 // Transcient suppression.
Andrew MacDonald 2015/10/02 21:46:04 s/Transcient/Transient But also a pretty useless
minyue-webrtc 2015/10/02 21:57:34 Oh, sorry for the typo
69 optional bool transient_suppression_enabled = 16;
minyue-webrtc 2015/10/02 19:59:59 not sure if it is possible/better to use a short n
Andrew MacDonald 2015/10/02 21:41:57 That would be nice, but it's not really a recogniz
minyue-webrtc 2015/10/02 21:57:34 Acknowledged.
70 }
71
42 message Event { 72 message Event {
43 enum Type { 73 enum Type {
44 INIT = 0; 74 INIT = 0;
45 REVERSE_STREAM = 1; 75 REVERSE_STREAM = 1;
46 STREAM = 2; 76 STREAM = 2;
77 CONFIG = 3;
78 UNKNOWN_EVENT = 4;
47 } 79 }
48 80
49 required Type type = 1; 81 required Type type = 1;
50 82
51 optional Init init = 2; 83 optional Init init = 2;
52 optional ReverseStream reverse_stream = 3; 84 optional ReverseStream reverse_stream = 3;
53 optional Stream stream = 4; 85 optional Stream stream = 4;
86 optional Config config = 5;
54 } 87 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698