 Chromium Code Reviews
 Chromium Code Reviews Issue 1348903004:
  Adding APM configuration in AEC dump.  (Closed) 
  Base URL: https://chromium.googlesource.com/external/webrtc.git@master
    
  
    Issue 1348903004:
  Adding APM configuration in AEC dump.  (Closed) 
  Base URL: https://chromium.googlesource.com/external/webrtc.git@master| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. | 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. | 
| 3 * | 3 * | 
| 4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license | 
| 5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source | 
| 6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found | 
| 7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may | 
| 8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. | 
| 9 */ | 9 */ | 
| 10 | 10 | 
| (...skipping 17 matching lines...) Expand all Loading... | |
| 28 | 28 | 
| 29 int ProcessRenderAudio(const AudioBuffer* audio); | 29 int ProcessRenderAudio(const AudioBuffer* audio); | 
| 30 int ProcessCaptureAudio(AudioBuffer* audio); | 30 int ProcessCaptureAudio(AudioBuffer* audio); | 
| 31 | 31 | 
| 32 // EchoControlMobile implementation. | 32 // EchoControlMobile implementation. | 
| 33 bool is_enabled() const override; | 33 bool is_enabled() const override; | 
| 34 | 34 | 
| 35 // ProcessingComponent implementation. | 35 // ProcessingComponent implementation. | 
| 36 int Initialize() override; | 36 int Initialize() override; | 
| 37 | 37 | 
| 38 RoutingMode routing_mode() const override; | |
| 39 | |
| 40 bool is_comfort_noise_enabled() const override; | |
| 
peah-webrtc
2015/09/22 12:05:29
Is it really needed to change the public/private s
 
minyue-webrtc
2015/09/22 13:19:29
Similar to suppression_level() in echo_cancellatio
 
peah-webrtc
2015/09/24 09:28:02
Acknowledged.
 | |
| 41 | |
| 38 private: | 42 private: | 
| 39 // EchoControlMobile implementation. | 43 // EchoControlMobile implementation. | 
| 40 int Enable(bool enable) override; | 44 int Enable(bool enable) override; | 
| 41 int set_routing_mode(RoutingMode mode) override; | 45 int set_routing_mode(RoutingMode mode) override; | 
| 42 RoutingMode routing_mode() const override; | |
| 43 int enable_comfort_noise(bool enable) override; | 46 int enable_comfort_noise(bool enable) override; | 
| 44 bool is_comfort_noise_enabled() const override; | |
| 45 int SetEchoPath(const void* echo_path, size_t size_bytes) override; | 47 int SetEchoPath(const void* echo_path, size_t size_bytes) override; | 
| 46 int GetEchoPath(void* echo_path, size_t size_bytes) const override; | 48 int GetEchoPath(void* echo_path, size_t size_bytes) const override; | 
| 47 | 49 | 
| 48 // ProcessingComponent implementation. | 50 // ProcessingComponent implementation. | 
| 49 void* CreateHandle() const override; | 51 void* CreateHandle() const override; | 
| 50 int InitializeHandle(void* handle) const override; | 52 int InitializeHandle(void* handle) const override; | 
| 51 int ConfigureHandle(void* handle) const override; | 53 int ConfigureHandle(void* handle) const override; | 
| 52 void DestroyHandle(void* handle) const override; | 54 void DestroyHandle(void* handle) const override; | 
| 53 int num_handles_required() const override; | 55 int num_handles_required() const override; | 
| 54 int GetHandleError(void* handle) const override; | 56 int GetHandleError(void* handle) const override; | 
| 55 | 57 | 
| 56 const AudioProcessing* apm_; | 58 const AudioProcessing* apm_; | 
| 57 CriticalSectionWrapper* crit_; | 59 CriticalSectionWrapper* crit_; | 
| 58 RoutingMode routing_mode_; | 60 RoutingMode routing_mode_; | 
| 59 bool comfort_noise_enabled_; | 61 bool comfort_noise_enabled_; | 
| 60 unsigned char* external_echo_path_; | 62 unsigned char* external_echo_path_; | 
| 61 }; | 63 }; | 
| 62 } // namespace webrtc | 64 } // namespace webrtc | 
| 63 | 65 | 
| 64 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CONTROL_MOBILE_IMPL_H_ | 66 #endif // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CONTROL_MOBILE_IMPL_H_ | 
| OLD | NEW |