Adding APM configuration in AEC dump.

webrtc/modules/audio_processing/echo_cancellation_impl.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 19 matching lines @@
   int ProcessCaptureAudio(AudioBuffer* audio);
 
   // EchoCancellation implementation.
   bool is_enabled() const override;
   int stream_drift_samples() const override;
 
   // ProcessingComponent implementation.
   int Initialize() override;
   void SetExtraOptions(const Config& config) override;
 
+  SuppressionLevel suppression_level() const override;

[peah-webrtc, 2015/09/22 12:05:29]

Is it really needed to change the public/private statuses of the member
functions? These are public in the EchoCancellation parent class and they are
publicly accessed from elsewhere so I don't think this api change is needed.

[minyue-webrtc, 2015/09/22 13:19:29]

The problem is the instantiate of echo canceler in APM is an
EchoCancellationImpl

[peah-webrtc, 2015/09/24 09:28:02]

After a discussion together we agreed that to comply with the ongoing locking
refactoring the submodules apis needs to anyway change according to this so it
is motivated to do the change you propose. And the mismatch in public/private
could as well be fixed at the same time.

[peah-webrtc, 2015/09/24 09:28:02]

Acknowledged.

+  bool is_drift_compensation_enabled() const override;
+  bool is_delay_logging_enabled() const override;
+  bool is_extended_filter_enabled() const;
+
  private:
   // EchoCancellation implementation.
   int Enable(bool enable) override;
   int enable_drift_compensation(bool enable) override;
-  bool is_drift_compensation_enabled() const override;
   void set_stream_drift_samples(int drift) override;
   int set_suppression_level(SuppressionLevel level) override;
-  SuppressionLevel suppression_level() const override;
   int enable_metrics(bool enable) override;
   bool are_metrics_enabled() const override;
   bool stream_has_echo() const override;
   int GetMetrics(Metrics* metrics) override;
   int enable_delay_logging(bool enable) override;
-  bool is_delay_logging_enabled() const override;
   int GetDelayMetrics(int* median, int* std) override;
   int GetDelayMetrics(int* median,
                       int* std,
                       float* fraction_poor_delays) override;
   struct AecCore* aec_core() const override;
 
   // ProcessingComponent implementation.
   void* CreateHandle() const override;
   int InitializeHandle(void* handle) const override;
   int ConfigureHandle(void* handle) const override;
@@ skipping 10 matching lines @@
   bool was_stream_drift_set_;
   bool stream_has_echo_;
   bool delay_logging_enabled_;
   bool extended_filter_enabled_;
   bool delay_agnostic_enabled_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_PROCESSING_ECHO_CANCELLATION_IMPL_H_