Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 1348113002: Move AudioDecoderPcm16B next to AudioEncoderPcm16B (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move AudioDecoderPcm16B next to AudioEncoderPcm16B All AudioDecoder subclasses have historically lived in NetEq, but they fit better with the codec they wrap. BUG=webrtc:4557 R=henrik.lundin@webrtc.org Committed: https://crrev.com/c0ac6cad00f51b99fafaa7c19e2e63b3b542735b Cr-Commit-Position: refs/heads/master@{#9963}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -83 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/pcm16b/audio_decoder_pcm16b.cc View 1 chunk +54 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_coding/codecs/pcm16b/include/audio_decoder_pcm16b.h View 1 2 2 chunks +18 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/pcm16b.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 2 2 chunks +1 line, -38 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kwiberg-webrtc
As noted elsewhere, this CL leads to the AudioDecoder subclass not being excluded from the ...
5 years, 3 months ago (2015-09-16 12:48:01 UTC) #2
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-16 12:52:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348113002/40001
5 years, 3 months ago (2015-09-17 05:44:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/796)
5 years, 3 months ago (2015-09-17 05:46:44 UTC) #8
kwiberg-webrtc
Committed patchset #3 (id:40001) manually as c0ac6cad00f51b99fafaa7c19e2e63b3b542735b (presubmit successful).
5 years, 3 months ago (2015-09-17 05:48:01 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 05:48:07 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c0ac6cad00f51b99fafaa7c19e2e63b3b542735b
Cr-Commit-Position: refs/heads/master@{#9963}

Powered by Google App Engine
This is Rietveld 408576698