Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 1348093002: Ensure all test targets are built on Android. (Closed)

Created:
5 years, 3 months ago by kjellander_webrtc
Modified:
5 years, 3 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald, phoglund
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Ensure all test targets are built on Android. When GYP runs for OS=android it doesn't generate the video_engine_core_unittests_apk_target target which is needed to get the APK built. The same problem applies to webrtc/test/webrtc_test_common.gyp, but that unittest is not added on any bot anyway, so that's future work. TESTED=Ran webrtc/build/gyp_webrtc for Linux and Android locally. Before this patch, the video_engine_core_unittests was not built as part of the 'All' target. With this patch, it is now built. R=pbos@webrtc.org Committed: https://crrev.com/afb6b5e3e0a2d7040e183d09e40071074017c0ad Cr-Commit-Position: refs/heads/master@{#9952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/webrtc.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kjellander_webrtc
5 years, 3 months ago (2015-09-16 11:58:09 UTC) #2
pbos-webrtc
lgtm assuming no platforms complain w/r/t circular dependencies or something like that (please CQ) :)
5 years, 3 months ago (2015-09-16 12:05:06 UTC) #3
kjellander_webrtc
Committed patchset #1 (id:1) manually as afb6b5e3e0a2d7040e183d09e40071074017c0ad (presubmit successful).
5 years, 3 months ago (2015-09-16 12:07:51 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/afb6b5e3e0a2d7040e183d09e40071074017c0ad Cr-Commit-Position: refs/heads/master@{#9952}
5 years, 3 months ago (2015-09-16 12:07:52 UTC) #5
kjellander_webrtc
5 years, 3 months ago (2015-09-16 12:19:01 UTC) #6
Message was sent while issue was closed.
On 2015/09/16 12:05:06, pbos-webrtc wrote:
> lgtm assuming no platforms complain w/r/t circular dependencies or something
> like that (please CQ) :)

Since we don't use the circular dependencies detection (unfortunately, see
https://code.google.com/p/webrtc/issues/detail?id=4243) there's no risk for
that.
I wanted to get this in to unblock the CQ as I clobbered one of the bots
earlier, causing it to start failing on every build.

Seems like this landed nicely on the bots.

Powered by Google App Engine
This is Rietveld 408576698