Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1348053002: Move AudioDecoderIlbc next to AudioEncoderIlbc (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move AudioDecoderIlbc next to AudioEncoderIlbc All AudioDecoder subclasses have historically lived in NetEq, but they fit better with the codec they wrap. BUG=webrtc:4557 Committed: https://crrev.com/fff9f176f542053ca7cb887c184c72ad3fc5755d Cr-Commit-Position: refs/heads/master@{#9961}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -68 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/ilbc/audio_decoder_ilbc.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/ilbc.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/ilbc/interface/audio_decoder_ilbc.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 2 chunks +0 lines, -26 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 2 chunks +1 line, -42 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
As noted elsewhere, this CL leads to the AudioDecoder subclass not being excluded from the ...
5 years, 3 months ago (2015-09-16 12:26:42 UTC) #2
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-16 12:40:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1348053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1348053002/20001
5 years, 3 months ago (2015-09-17 04:24:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 04:26:37 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 04:26:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fff9f176f542053ca7cb887c184c72ad3fc5755d
Cr-Commit-Position: refs/heads/master@{#9961}

Powered by Google App Engine
This is Rietveld 408576698