Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: webrtc/video_engine/payload_router.h

Issue 1347793005: Replace Atomic32 with webrtc/base/atomicops.h. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: fix typo Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_VIDEO_ENGINE_PAYLOAD_ROUTER_H_ 11 #ifndef WEBRTC_VIDEO_ENGINE_PAYLOAD_ROUTER_H_
12 #define WEBRTC_VIDEO_ENGINE_PAYLOAD_ROUTER_H_ 12 #define WEBRTC_VIDEO_ENGINE_PAYLOAD_ROUTER_H_
13 13
14 #include <list> 14 #include <list>
15 #include <vector> 15 #include <vector>
16 16
17 #include "webrtc/base/atomicops.h"
17 #include "webrtc/base/constructormagic.h" 18 #include "webrtc/base/constructormagic.h"
18 #include "webrtc/base/scoped_ptr.h" 19 #include "webrtc/base/scoped_ptr.h"
19 #include "webrtc/base/thread_annotations.h" 20 #include "webrtc/base/thread_annotations.h"
20 #include "webrtc/common_types.h" 21 #include "webrtc/common_types.h"
21 #include "webrtc/system_wrappers/interface/atomic32.h"
22 22
23 namespace webrtc { 23 namespace webrtc {
24 24
25 class CriticalSectionWrapper; 25 class CriticalSectionWrapper;
26 class RTPFragmentationHeader; 26 class RTPFragmentationHeader;
27 class RtpRtcp; 27 class RtpRtcp;
28 struct RTPVideoHeader; 28 struct RTPVideoHeader;
29 29
30 // PayloadRouter routes outgoing data to the correct sending RTP module, based 30 // PayloadRouter routes outgoing data to the correct sending RTP module, based
31 // on the simulcast layer in RTPVideoHeader. 31 // on the simulcast layer in RTPVideoHeader.
(...skipping 24 matching lines...) Expand all
56 const RTPVideoHeader* rtp_video_hdr); 56 const RTPVideoHeader* rtp_video_hdr);
57 57
58 // Configures current target bitrate per module. 'stream_bitrates' is assumed 58 // Configures current target bitrate per module. 'stream_bitrates' is assumed
59 // to be in the same order as 'SetSendingRtpModules'. 59 // to be in the same order as 'SetSendingRtpModules'.
60 void SetTargetSendBitrates(const std::vector<uint32_t>& stream_bitrates); 60 void SetTargetSendBitrates(const std::vector<uint32_t>& stream_bitrates);
61 61
62 // Returns the maximum allowed data payload length, given the configured MTU 62 // Returns the maximum allowed data payload length, given the configured MTU
63 // and RTP headers. 63 // and RTP headers.
64 size_t MaxPayloadLength() const; 64 size_t MaxPayloadLength() const;
65 65
66 void AddRef() { ++ref_count_; } 66 void AddRef() { rtc::AtomicOps::Increment(&ref_count_); }
67 void Release() { if (--ref_count_ == 0) { delete this; } } 67 void Release() {
68 if (rtc::AtomicOps::Decrement(&ref_count_) == 0) {
69 delete this;
70 }
71 }
68 72
69 private: 73 private:
70 // TODO(mflodman): When the new video API has launched, remove crit_ and 74 // TODO(mflodman): When the new video API has launched, remove crit_ and
71 // assume rtp_modules_ will never change during a call. 75 // assume rtp_modules_ will never change during a call.
72 rtc::scoped_ptr<CriticalSectionWrapper> crit_; 76 rtc::scoped_ptr<CriticalSectionWrapper> crit_;
73 77
74 // Active sending RTP modules, in layer order. 78 // Active sending RTP modules, in layer order.
75 std::vector<RtpRtcp*> rtp_modules_ GUARDED_BY(crit_.get()); 79 std::vector<RtpRtcp*> rtp_modules_ GUARDED_BY(crit_.get());
76 bool active_ GUARDED_BY(crit_.get()); 80 bool active_ GUARDED_BY(crit_.get());
77 81
78 Atomic32 ref_count_; 82 volatile int ref_count_;
79 83
80 RTC_DISALLOW_COPY_AND_ASSIGN(PayloadRouter); 84 RTC_DISALLOW_COPY_AND_ASSIGN(PayloadRouter);
81 }; 85 };
82 86
83 } // namespace webrtc 87 } // namespace webrtc
84 88
85 #endif // WEBRTC_VIDEO_ENGINE_PAYLOAD_ROUTER_H_ 89 #endif // WEBRTC_VIDEO_ENGINE_PAYLOAD_ROUTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698