Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h

Issue 1347793005: Replace Atomic32 with webrtc/base/atomicops.h. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: fix typo Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_ 11 #ifndef WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_
12 #define WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_ 12 #define WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR_H_
13 13
14 #include <ApplicationServices/ApplicationServices.h> 14 #include <ApplicationServices/ApplicationServices.h>
15 15
16 #include "webrtc/base/atomicops.h"
16 #include "webrtc/modules/desktop_capture/window_capturer.h" 17 #include "webrtc/modules/desktop_capture/window_capturer.h"
17 #include "webrtc/system_wrappers/interface/atomic32.h"
18 #include "webrtc/system_wrappers/interface/tick_util.h" 18 #include "webrtc/system_wrappers/interface/tick_util.h"
19 19
20 namespace webrtc { 20 namespace webrtc {
21 21
22 // This is a work around for the Chrome tab full-screen behavior: Chrome 22 // This is a work around for the Chrome tab full-screen behavior: Chrome
23 // creates a new window in full-screen mode to show a tab full-screen and 23 // creates a new window in full-screen mode to show a tab full-screen and
24 // minimizes the old window. To continue capturing in this case, we try to 24 // minimizes the old window. To continue capturing in this case, we try to
25 // find the new full-screen window using these criteria: 25 // find the new full-screen window using these criteria:
26 // 0. The original shared window is minimized. 26 // 0. The original shared window is minimized.
27 // 1. The original shared window's owner application name is "Google Chrome". 27 // 1. The original shared window's owner application name is "Google Chrome".
28 // 2. The original window and the new window have the same title and owner 28 // 2. The original window and the new window have the same title and owner
29 // pid. 29 // pid.
30 // 3. The new window is full-screen. 30 // 3. The new window is full-screen.
31 // 4. The new window didn't exist at least 500 millisecond ago. 31 // 4. The new window didn't exist at least 500 millisecond ago.
32 32
33 class FullScreenChromeWindowDetector { 33 class FullScreenChromeWindowDetector {
34 public: 34 public:
35 FullScreenChromeWindowDetector(); 35 FullScreenChromeWindowDetector();
36 36
37 void AddRef() { ++ref_count_; } 37 void AddRef() { rtc::AtomicOps::Increment(&ref_count_); }
38 void Release() { 38 void Release() {
39 if (--ref_count_ == 0) 39 if (rtc::AtomicOps::Decrement(&ref_count_) == 0)
40 delete this; 40 delete this;
41 } 41 }
42 42
43 // Returns the full-screen window in place of the original window if all the 43 // Returns the full-screen window in place of the original window if all the
44 // criteria are met, or kCGNullWindowID if no such window found. 44 // criteria are met, or kCGNullWindowID if no such window found.
45 CGWindowID FindFullScreenWindow(CGWindowID original_window); 45 CGWindowID FindFullScreenWindow(CGWindowID original_window);
46 46
47 // The caller should call this function periodically, no less than twice per 47 // The caller should call this function periodically, no less than twice per
48 // second. 48 // second.
49 void UpdateWindowListIfNeeded(CGWindowID original_window); 49 void UpdateWindowListIfNeeded(CGWindowID original_window);
50 50
51 private: 51 private:
52 ~FullScreenChromeWindowDetector(); 52 ~FullScreenChromeWindowDetector();
53 53
54 Atomic32 ref_count_; 54 volatile int ref_count_;
55 55
56 // We cache the last two results of the window list, so 56 // We cache the last two results of the window list, so
57 // |previous_window_list_| is taken at least 500ms before the next Capture() 57 // |previous_window_list_| is taken at least 500ms before the next Capture()
58 // call. If we only save the last result, we may get false positive (i.e. 58 // call. If we only save the last result, we may get false positive (i.e.
59 // full-screen window exists in the list) if Capture() is called too soon. 59 // full-screen window exists in the list) if Capture() is called too soon.
60 WindowCapturer::WindowList current_window_list_; 60 WindowCapturer::WindowList current_window_list_;
61 WindowCapturer::WindowList previous_window_list_; 61 WindowCapturer::WindowList previous_window_list_;
62 TickTime last_udpate_time_; 62 TickTime last_udpate_time_;
63 63
64 RTC_DISALLOW_COPY_AND_ASSIGN(FullScreenChromeWindowDetector); 64 RTC_DISALLOW_COPY_AND_ASSIGN(FullScreenChromeWindowDetector);
65 }; 65 };
66 66
67 } // namespace webrtc 67 } // namespace webrtc
68 68
69 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR _H_ 69 #endif // WEBRTC_MODULES_DESKTOP_CAPTURE_MAC_FULL_SCREEN_CHROME_WINDOW_DETECTOR _H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698