Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1347353004: Reduce LS_INFO spam from voice_engine/. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reduce LS_INFO spam from voice_engine/. Removes ShouldIgnoreTrace from WebRtcVoiceEngine and removes the spammy log instances instead. Also removes trace-style logging from getters (::GetLocalSSRC() for instance would print what SSRC it got, spamming the log). BUG= R=henrika@webrtc.org Committed: https://crrev.com/d5c75b1a0ba1548d3561109e3e5e63757509e9ae Cr-Commit-Position: refs/heads/master@{#10028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -402 lines) Patch
M talk/media/webrtc/webrtcvoiceengine.h View 1 chunk +0 lines, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 2 chunks +1 line, -31 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 40 chunks +2 lines, -149 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/voe_audio_processing_impl.cc View 22 chunks +0 lines, -52 lines 0 comments Download
M webrtc/voice_engine/voe_codec_impl.cc View 9 chunks +0 lines, -36 lines 0 comments Download
M webrtc/voice_engine/voe_dtmf_impl.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M webrtc/voice_engine/voe_external_media_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/voe_file_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voe_hardware_impl.cc View 9 chunks +0 lines, -38 lines 0 comments Download
M webrtc/voice_engine/voe_neteq_stats_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/voe_rtp_rtcp_impl.cc View 9 chunks +0 lines, -19 lines 0 comments Download
M webrtc/voice_engine/voe_video_sync_impl.cc View 5 chunks +0 lines, -17 lines 0 comments Download
M webrtc/voice_engine/voe_volume_control_impl.cc View 9 chunks +0 lines, -36 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pbos-webrtc
PTAL, these did remove the log lines you sent in a mail. I'm not sure ...
5 years, 3 months ago (2015-09-22 15:58:53 UTC) #1
henrika_webrtc
Many thanks Peter! LGTM
5 years, 3 months ago (2015-09-23 07:02:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347353004/1
5 years, 3 months ago (2015-09-23 09:30:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_compile_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_compile_dbg/builds/43) win_drmemory_light on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-09-23 09:53:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347353004/1
5 years, 3 months ago (2015-09-23 11:14:39 UTC) #8
pbos-webrtc
Committed patchset #1 (id:1) manually as d5c75b1a0ba1548d3561109e3e5e63757509e9ae (presubmit successful).
5 years, 3 months ago (2015-09-23 11:24:49 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 11:24:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5c75b1a0ba1548d3561109e3e5e63757509e9ae
Cr-Commit-Position: refs/heads/master@{#10028}

Powered by Google App Engine
This is Rietveld 408576698