Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1347283004: Remove ViEChannel::StartSend deadlock suppression. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), Andrew MacDonald
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ViEChannel::StartSend deadlock suppression. No longer lock-order inverting since RTP/RTCP modules are instantiated on construction and no longer guarded by a separate lock. BUG=webrtc:2999 R=stefan@webrtc.org Committed: https://crrev.com/7cf04452622e8622151d8ab13a43daa437bb8ee1 Cr-Commit-Position: refs/heads/master@{#10034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/build/sanitizers/tsan_suppressions_webrtc.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pbos-webrtc
Hardest CL of your life. PTAL. :)
5 years, 3 months ago (2015-09-18 10:12:42 UTC) #1
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-23 14:58:09 UTC) #2
pbos-webrtc
Committed patchset #1 (id:1) manually as 7cf04452622e8622151d8ab13a43daa437bb8ee1 (presubmit successful).
5 years, 3 months ago (2015-09-23 15:04:16 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 15:04:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cf04452622e8622151d8ab13a43daa437bb8ee1
Cr-Commit-Position: refs/heads/master@{#10034}

Powered by Google App Engine
This is Rietveld 408576698