Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1347243003: Reduces default sample rate from 44.1kHz to 16kHz (Closed)

Created:
5 years, 3 months ago by henrika_webrtc
Modified:
5 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
sophiechang-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reduces default sample rate from 44.1kHz to 16kHz to ensure that we can open up audio in communication mode also on older devices that only supports it in combination with 16kHz. BUG=webrtc:4756 R=magjed@webrtc.org Committed: https://crrev.com/48c46dbad202d190b8a76967908df32516015316 Cr-Commit-Position: refs/heads/master@{#9971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
henrika_webrtc
Please take a look Magnus.
5 years, 3 months ago (2015-09-17 13:57:38 UTC) #2
magjed_webrtc
lgtm
5 years, 3 months ago (2015-09-17 13:59:22 UTC) #3
henrika_webrtc
Committed patchset #1 (id:1) manually as 48c46dbad202d190b8a76967908df32516015316 (presubmit successful).
5 years, 3 months ago (2015-09-17 14:00:11 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 14:00:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48c46dbad202d190b8a76967908df32516015316
Cr-Commit-Position: refs/heads/master@{#9971}

Powered by Google App Engine
This is Rietveld 408576698