Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 1347083003: Remove the video capture module on Android. (Closed)

Created:
5 years, 3 months ago by perkj_webrtc
Modified:
5 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, qiang.lu, niklas.enbom, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the video capture module on Android. Video capture for android is now implemented in talk/app/webrtc/androidvideocapturer.h BUG=webrtc:4475 Committed: https://crrev.com/35d1767cc3ae1fd48e8fd01b0b8ed9061734538e Cr-Commit-Position: refs/heads/master@{#9995}

Patch Set 1 : #

Patch Set 2 : Removed Android Java files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1781 lines) Patch
M talk/libjingle.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/build/apk_tests.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
M webrtc/build/apk_tests_noop.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/examples/android/media_demo/src/org/webrtc/webrtcdemo/MediaCodecVideoDecoder.java View 1 chunk +0 lines, -338 lines 0 comments Download
M webrtc/modules/modules_java.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/modules_java_chromium.gyp View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D webrtc/modules/video_capture/android/device_info_android.h View 1 chunk +0 lines, -71 lines 0 comments Download
D webrtc/modules/video_capture/android/device_info_android.cc View 1 chunk +0 lines, -256 lines 0 comments Download
D webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/VideoCaptureAndroid.java View 1 1 chunk +0 lines, -463 lines 0 comments Download
D webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/VideoCaptureDeviceInfoAndroid.java View 1 1 chunk +0 lines, -133 lines 0 comments Download
D webrtc/modules/video_capture/android/video_capture_android.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/modules/video_capture/android/video_capture_android.cc View 1 chunk +0 lines, -255 lines 0 comments Download
D webrtc/modules/video_capture/ensure_initialized.h View 1 chunk +0 lines, -19 lines 0 comments Download
D webrtc/modules/video_capture/ensure_initialized.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/video_capture.gypi View 7 chunks +7 lines, -70 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_factory.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
perkj_webrtc
New attempt in the new code review system. Should be the same as https://webrtc-codereview.appspot.com/48719004/.
5 years, 3 months ago (2015-09-17 10:05:53 UTC) #3
perkj_webrtc
please ?
5 years, 3 months ago (2015-09-17 11:24:15 UTC) #4
kjellander_webrtc
What happened to: webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/VideoCaptureAndroid.java webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/VideoCaptureDeviceInfoAndroid.java They were removed in the old CL (and still exists).
5 years, 3 months ago (2015-09-17 11:56:58 UTC) #5
perkj_webrtc
Oops. Good catch. Now they are also removed.
5 years, 3 months ago (2015-09-18 08:51:46 UTC) #6
mflodman
RS LGTM, glancing through some files and assuming the rest is the same too.
5 years, 3 months ago (2015-09-20 08:40:14 UTC) #7
kjellander_webrtc
lgtm
5 years, 3 months ago (2015-09-21 03:51:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347083003/40001
5 years, 3 months ago (2015-09-21 08:00:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-21 08:46:38 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 08:46:47 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35d1767cc3ae1fd48e8fd01b0b8ed9061734538e
Cr-Commit-Position: refs/heads/master@{#9995}

Powered by Google App Engine
This is Rietveld 408576698