Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1346993002: Move AudioDecoderG722 next to AudioEncoderG722 (Closed)

Created:
5 years, 3 months ago by kwiberg-webrtc
Modified:
5 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, kwiberg-webrtc, tlegrand-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move AudioDecoderG722 next to AudioEncoderG722 All AudioDecoder subclasses have historically lived in NetEq, but they fit better with the codec they wrap. BUG=webrtc:4557 Committed: https://crrev.com/ada4c130ab576120380d48f29908b6cc20ec9cf5 Cr-Commit-Position: refs/heads/master@{#9966}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -176 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/g722/audio_decoder_g722.cc View 1 2 1 chunk +138 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A webrtc/modules/audio_coding/codecs/g722/include/audio_decoder_g722.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.h View 1 1 chunk +0 lines, -52 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_impl.cc View 1 2 2 chunks +1 line, -124 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
As noted elsewhere, this CL leads to the AudioDecoder subclass not being excluded from the ...
5 years, 3 months ago (2015-09-16 12:25:56 UTC) #2
hlundin-webrtc
lgtm
5 years, 3 months ago (2015-09-16 12:38:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346993002/40001
5 years, 3 months ago (2015-09-17 09:06:14 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-17 10:12:38 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 10:12:45 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ada4c130ab576120380d48f29908b6cc20ec9cf5
Cr-Commit-Position: refs/heads/master@{#9966}

Powered by Google App Engine
This is Rietveld 408576698