Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346643002: Remove id from VideoProcessingModule. (Closed)

Created:
5 years, 3 months ago by pbos-webrtc
Modified:
5 years, 3 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove id from VideoProcessingModule. Also converts CriticalSectionWrapper to rtc::CriticalSection as a bonus. BUG=webrtc:1695 R=stefan@webrtc.org Committed: https://crrev.com/f4aa4c2283c1c85f0e69aad69355889a66e99388 Cr-Commit-Position: refs/heads/master@{#9986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -30 lines) Patch
M webrtc/modules/video_processing/main/interface/video_processing.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/main/source/video_processing_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/video_processing/main/source/video_processing_impl.cc View 3 chunks +17 lines, -22 lines 0 comments Download
M webrtc/modules/video_processing/main/test/unit_test/video_processing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
pbos-webrtc
PTAL at this fabulous piece of rocket science. (:
5 years, 3 months ago (2015-09-15 15:38:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346643002/1
5 years, 3 months ago (2015-09-15 15:39:14 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/2348)
5 years, 3 months ago (2015-09-15 16:55:36 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346643002/1
5 years, 3 months ago (2015-09-16 12:49:08 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-09-16 14:49:25 UTC) #11
stefan-webrtc
lgtm
5 years, 3 months ago (2015-09-17 11:39:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346643002/1
5 years, 3 months ago (2015-09-17 11:57:21 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_drmemory_light on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
5 years, 3 months ago (2015-09-17 13:57:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1346643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1346643002/1
5 years, 3 months ago (2015-09-17 21:01:11 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android/builds/7790) android_arm64_rel on tryserver.webrtc (JOB_FAILED, ...
5 years, 3 months ago (2015-09-17 21:44:21 UTC) #20
pbos-webrtc
Committed patchset #1 (id:1) manually as f4aa4c2283c1c85f0e69aad69355889a66e99388 (presubmit successful).
5 years, 3 months ago (2015-09-18 10:24:39 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 10:24:43 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f4aa4c2283c1c85f0e69aad69355889a66e99388
Cr-Commit-Position: refs/heads/master@{#9986}

Powered by Google App Engine
This is Rietveld 408576698